Repository navigation
Fix Plugin Check CI - #194
Merged
Merged
Conversation
The same fix as progress-planner#766. The job failed on about half of all runs, depending on the GitHub token minted for the run: setup-php stores it in ~/.composer/auth.json, and Composer rejects it when it contains a character its validator dislikes (composer#12076). dist-archive-command is public, so the stored credential is removed before installing it. Also pins dist-archive-command to v3.1.0 (the newest release that accepts the WP-CLI 2.12 setup-php provides; ^3.1 can resolve to 3.2.x, which needs WP-CLI 2.13) and moves plugin-check-action to v1.1.9, which fixes the wp-env startup failure. The workflow comments explain both pins. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Filip Ilic <ilic.filip@gmail.com>
|
Test on Playground |
🔍 WordPress Plugin Check Report
📊 Report
|
| 📍 Line | 🔖 Check | 💬 Message |
|---|---|---|
0 |
textdomain_mismatch | The "Text Domain" header in the plugin file does not match the slug. Found "yoast-comment-hacks", expected "comment-hacks". |
🤖 Generated by WordPress Plugin Check Action • Learn more about Plugin Check
Plugin Check requires the current WordPress version. Checked on WordPress 7.1.2 with PHP 8.3: the plugin activates and its screens load without PHP notices, warnings or errors. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Filip Ilic <ilic.filip@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Plugin Check job fails at random. It copies the fix from ProgressPlanner/progress-planner#766.
The issue:
setup-phpsaves the run's temporary GitHub token in~/.composer/auth.json. Composer rejects that token when it happens to contain certain characters (composer#12076): "Your github oauth token for github.com contains invalid characters". So about half of all runs fail before anything is checked, and re-running sometimes "fixes" it.The fix:
Delete the stored token before installing
dist-archive-command. It's a public package, so it needs no auth.Pin
dist-archive-commandtov3.1.0instead of^3.1. v3.2.x needs WP-CLI 2.13, which has no stable release.Move
plugin-check-actionfrom v1.1.5 to v1.1.9, which fixes the "Environment not initialized" wp-env failure.Set
Tested up to: 7.1inreadme.txt, which Plugin Check now requires once it can run. Checked on WordPress 7.1.2 with PHP 8.3: the plugin activates and its screens load without PHP errors.The workflow comments explain both pins, so nobody "updates" them back into breakage. Because the failure depends on the token, one green run proves little: an occasional red run here means the job hit something else.
🤖 Generated with Claude Code