enhancement(evaluation): Reference summary findings by question number - #1173
Conversation
|
Important Review skippedAuto reviews are limited based on label configuration. 🏷️ Required labels (at least one) (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
OpenAPI changes ⚪ No API surface changesNote This PR does not modify the API contract.
|
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Issue
Closes #1174
Summary
The evaluation run summary keyed each per-question judge trace on the Langfuse dataset item id (
item_{row}_{dup}) and told the summary model to cite that id. Reviewers got a "Top 3 to check" list ofitem_3_1/item_12_4, which cannot be mapped back to a question without opening Langfuse — and with duplication factor > 1 the same question appears under several ids, so one bad question could eat all three slots.question_id(app/crud/evaluations/summary.py):_format_traces_for_prompthands over the 1-based dataset row number instead oftrace_id, and the system prompt asks the model to reference each question as "Question N".question_idwas already populated end to end (langfuse.pywrites it into trace metadata,merge.pypreserves and sorts on it), so this is a consumer-side change only.EVAL_JUDGE_MODELmoves fromgpt-5-minitogpt-5.6-luna(app/core/config.py).app/tests/crud/evaluations/test_run_ai_summary.py).Checklist
Before submitting a pull request, please ensure that you mark these task.
fastapi run --reload app/main.pyordocker compose upin the repository root and test.Notes
The ground-truth judge prompt rewrite that was previously on this branch has been reverted — this PR is now scoped to the summary id change and the judge model bump.