Repository navigation
Conversation
EmptyArray (an empty array, or lists that are all empty) becomes a Float64[], as in ak.to_numpy. A RegularArray of size 0 cannot infer its length from its content and raised a DivideError, so each node now gets its length from its parent. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## ssd/imas_composer_call #111 +/- ##
==========================================================
+ Coverage 43.97% 44.11% +0.14%
==========================================================
Files 17 17
Lines 31580 31675 +95
==========================================================
+ Hits 13887 13975 +88
- Misses 17693 17700 +7 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
AreWeDreaming
requested changes
Nov 4, 2026
AreWeDreaming
left a comment
AreWeDreaming
left a comment
There was a problem hiding this comment.
Some small tweaks. Not tested. We could also add CI for this. All we'd need is a new persistent FDP BEARER_TOKEN.
| return IMASdd.awkward_from_buffers(form, pyconvert(Int, value["length"]), buffers) | ||
| end | ||
|
|
||
| function IMASdd.imas_composer2imas(shot::Integer, fields::AbstractVector, @nospecialize(ids::IMASdd.DD)=IMASdd.dd_nospecialize(); kw...) |
There was a problem hiding this comment.
We need to be able to forward the various imas_composer simple load arguments:
efit_tree: EFIT tree (default: 'EFIT01', ignored if composer provided)
efit_run_id: Run id appended to pulse for 'EFIT' tree (default: '')
profiles_tree: Profiles tree (default: 'ZIPFIT01', ignored if composer provided)
profiles_run_id: Run ID appended to pulse for OMFIT_PROFS tree (default: '')
mentioning these because this feature was created for FUSE
crop_core_profiles: Whether to crop core_profiles to inside the separatrix (rho <= 1)
The following we can ignore for now:
fast_ece: Whether to load fast_ece data (default: False)
include_rip: Whether to include RIP data for interferometer IDS (default: False)
max_iterations: Maximum resolve-fetch iterations (default: 10)
|
Given that the codecov is complaining, I'd say we wait with merging until we get an FDP token for this Org and add Ci. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added handling of zero length awkward array.
Added basic run tests for transfer