Skip to content

Fix diff() erroring on NaN parameter values; fix vector diff comparing p1 to itself #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jmcclena merged 2 commits into from
Nov 3, 2026
Merged

Fix diff() erroring on NaN parameter values; fix vector diff comparing p1 to itself #21

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
854a3e3
fix: treat NaN values as equal in diff comparisons
tomneiser Jul 23, 2026
d0be721
Revert version bump; done after merge per repo convention
tomneiser Jul 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 2 additions & 9 deletions src/io.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,15 +13,8 @@ function par2ystr(par::AbstractParametersVector, txt::Vector{String}; show_info:
end
end

function equals_with_missing(a, b)
if ismissing(a) && ismissing(b)
return true
elseif ismissing(a) || ismissing(b)
return false
else
return a == b
end
end
# isequal treats missing==missing and NaN==NaN as true, unlike ==
equals_with_missing(a, b) = isequal(a, b)

function YAML._print(io::IO, value::Missing, level::Int=0, ignore_level::Bool=false)
return println(io, "~")
Expand Down
2 changes: 1 addition & 1 deletion src/utils.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ function Base.diff(p1::AbstractParametersVector, p2::AbstractParametersVector)
end
for key in commonkeys
v1 = p1[key]
v2 = p1[key]
v2 = p2[key]
if typeof(v1) !== typeof(v2)
error("$key is of different type")
elseif typeof(v1) <: AbstractParameters
Expand Down
Loading