Skip to content

[Mips] Do not move a load/store across a call in adjustForDelaySlot #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
qethu merged 1 commit into from
Sep 14, 2026
Merged

[Mips] Do not move a load/store across a call in adjustForDelaySlot #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions llvm/lib/Target/Mips/MipsDelaySlotFiller.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -597,6 +597,22 @@ static int getEquivalentCallShort(int Opcode) {
static bool canSwapLoadStoreWith(const MachineInstr &I, const MachineInstr &N) {
if (N.mayLoadOrStore())
return false;
// Never move a load/store across a call, a terminator, or anything with
// unmodeled side effects: a call's clobbers are a register mask, not
// register operands, so the operand scan below cannot see that the
// caller-saved register the store reads (e.g. $1/$at) dies at the call.
if (N.isCall() || N.isTerminator() || N.isBranch() ||
N.hasUnmodeledSideEffects() || N.isInlineAsm())
return false;
for (const auto &MO_N : N.operands()) {
if (!MO_N.isRegMask())
continue;
for (const auto &MO_I : I.operands()) {
if (MO_I.isReg() && MO_I.getReg().isPhysical() &&
MO_N.clobbersPhysReg(MO_I.getReg()))
return false;
}
}
bool ImayLoad = I.mayLoad();

auto *Fn = I.getParent()->getParent();
Expand Down