Repository navigation
Coq system - #915
Merged
Merged
Coq system#915
Conversation
Freeze the current behavior: file and directory variables have priority over the project file for coq-load-path and coq-prog-args, one by one; coq-pg-detect-programs detects the Coq program by default and keeps the one asked (proof-prog-name-ask) or customized. Coq is not started. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
coq-pg-detect-programs, run just before starting Coq, replaced them by the detected programs: coq--user-set-p only recognized customized options, and proof-prog-name was copied from coq-prog-name by coq-pg-setup, before the file variables are set. coq--user-set-p now also recognizes buffer-local values (file and directory variables), and coq-pg-detect-programs copies a buffer-local coq-prog-name to proof-prog-name, unless proof-prog-name-ask asked it. As for a customized coq-prog-name, the compiler and coqdep are then looked for in its directory. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
New coq--version-at-least and coq--version-before; the coq--post-vXX and coq--pre-vXX become one-liners with the same thresholds and defaults. Their condition-case was dead code: coq--version< already returns nil on invalid versions. Checked identical on 25 versions, invalid ones included. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
It is used only by a test of omit proofs, skipped before Coq 8.9 (#[local] hints). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
coq-detect-rocq-cli runs the Coq program each time, and it is called several times at load time and before each start of Coq (to detect coqc, coqdep, and their arguments). Cache its result per command, remote host of default-directory and exec-path (which changes with the opam switch, for example). A command that cannot be run is not cached. The result is now t instead of a match position. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
coq--options-test-roundtrips and its helpers, in coq-system.el, printed the checks in a buffer and were called by nobody. They become the ERT test coq-test-system-options-roundtrip. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Both were deprecated and read by nobody. The comment "DEAD CODE?" on coq-prog-env is wrong: it is also defined by defpgcustom in pg-custom.el, and passed to the Coq process by Proof General. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Coq: file variables for the Coq program, and cleanup of coq-system.el
Tested on rocq-9.2, rocq-9.0 and coq-8.20, interpreted and compiled.