Repository navigation
Common keys - #916
Open
Matafou wants to merge 4 commits into
Open
Common keys#916Matafou wants to merge 4 commits into
Matafou wants to merge 4 commits into
Conversation
…tests). coq-mode-map is the keymap of Coq mode in all backends, and with Proof General it has priority over proof-mode-map. Document it in the manual and in CHANGES: to keep their key bindings with another backend, users define them in coq-mode-map, preferably on the common commands. Tests: a key binding of the user in coq-mode-map, also by local-set-key in coq-mode-hook, applies without Proof General; with it, it has priority over proof-mode-map, whose key bindings apply too. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ls and response buffers. The goals and response buffers had their own copy of the default keys of the queries and of the display, so that the key bindings of the user in coq-mode-map did not apply there, and each backend had to redo it. coq-all-buffers-commands lists the commands of the script buffer that make sense there too (queries, display, printing options), and coq-all-buffers-keymap returns a keymap with their key bindings in coq-mode-map, default and of the user, plus C-c C-a C-r and C-c C-a C-g (store the response and the goals, insertions in the script buffer). Proof General makes it a parent of coq-goals-mode-map and coq-response-mode-map, before its generic keymaps, each time these buffers are set up: after the configuration of the user, whose key bindings in these mode maps keep the priority. The keys of the hypotheses (f, F, h, H) stay in the goals buffer only. Tests, with and without Proof General, and doc. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
coq-store-buffer-win displayed the buffer in another frame each time: storing the goals or the response again, for instance with C-c C-a C-r from *response-freeze* (which has the keys of the response buffer), opened a new frame. Reuse the visible window that displays it, if any. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
They were bound to [q] and [c], the event symbols q and c, not the characters, so they never worked: the keys q and c are undefined in these buffers (proof-universal-keys-only-mode). Rather than enabling them after all this time, keep the working version in a comment, with the question whether they are really useful. No change of behavior. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Coq: key bindings for all backends, and fixes in the goals and response buffers