Repository navigation
Strip upstream integrations, vendor Docker deploy, rebrand to Zipherscan - #6
Conversation
ronkq
commented
Sep 17, 2026
- Remove upstream analytics, donations, Telegram signals, and CDN calls
- Drop Redis; vendor the deployment Dockerfiles instead
- Clean up remaining signals references left over from zsa1
- Document running locally against the QED-it ZSA1_1 node
- Rename repo references from Cipherscan to Zipherscan; add Zipherscan section to README
PaulLaux
left a comment
There was a problem hiding this comment.
Added some comments. Plus:
Please cleanup the main readme.md - we don't need to preserve nothing that is not relevant to ZSA:
- Some things need to change to Zipherscan. some things need to stay Cipherscan. Some things need to go away completely. Keep only the absolute essentials.
Also, We don't need two sets of dockerfile and two sets of docker-compose. Only properly-named files with what we need.
Also, npm run dev should get info from https://rpc.test-zsa.org not from public zebra node.
Did not tested api localy. will be waiting for the docs/run-locally.md file.
|
|
||
| **What differs from upstream** | ||
|
|
||
| - Targets QED-it's ZSA1_1 testnet node (`https://rpc.test-zsa.org`) rather than the public Zcash networks. See [docs/run-locally.md](docs/run-locally.md) for running it and for connecting to that node or your own ZSA zebrad. |
There was a problem hiding this comment.
Sorry, was missed because of .gitignore
Added now
| title: 'ZipherScan Testnet - Zcash Testnet Explorer for TAZ', | ||
| description: 'Explore the Zcash testnet with ZipherScan. Search TAZ blocks, transactions, and addresses, monitor pending transactions, and inspect testnet network activity.', |
| } from './solar'; | ||
|
|
||
| const WORLD_TOPO_URL = 'https://cdn.jsdelivr.net/npm/world-atlas@2/land-110m.json'; | ||
| const WORLD_TOPO_URL = '/land-110m.json'; |
| **What differs from upstream** | ||
|
|
||
| - Targets QED-it's ZSA1_1 testnet node (`https://rpc.test-zsa.org`) rather than the public Zcash networks. See [docs/run-locally.md](docs/run-locally.md) for running it and for connecting to that node or your own ZSA zebrad. | ||
| - Upstream analytics, donation UI, Telegram signals and third-party CDN calls are removed. Redis is optional. |
There was a problem hiding this comment.
I see redis removed completely from package.json. Is it stil optional?
There was a problem hiding this comment.
Correct, removed completly and not optional
| lightwalletd: | ||
| profiles: [local-node] |
| `NEXT_PUBLIC_*` values are compiled into the browser bundle, so the API URL is a | ||
| **build arg** — setting it at runtime in compose has no effect. Without it the | ||
| bundle falls back to `DEFAULT_API_URLS` in `lib/api-config.ts`, which points at | ||
| upstream's `api.testnet.cipherscan.app`. |
There was a problem hiding this comment.
The default should be test-zsa.org. Nothing should default to regular non zsa version.
| ## api | ||
|
|
||
| Build from the **repository root**, not `server/api` — the Dockerfile copies | ||
| `server/lib/` and `server/signals/`, which are outside that directory. The |
There was a problem hiding this comment.
You removed server/signals/ from this branch
There was a problem hiding this comment.
Updated the line, fixed
f977c6c to
b62dd0e
Compare
dev-zipherscan-indexer is built from Kenbak/cipherscan-rust, not from this repo, and tagged zsa-<commit>. Add it to the image table and describe what the image contains, since the Dockerfile is not committed anywhere.
Rewrote and kept the essentials of the readme.md |
The API rejected https://cipherscan.test-zsa.org in both its CORS and WebSocket allowlists, so browser POSTs through the /api proxy got a 500 and the WebSocket a 403. The WebSocket also connected to "/", which Next serves as a page and closes on upgrade (502); /api/ws goes through the proxy. CORS_ORIGINS now extends both allowlists, and ECR.md builds web with the site origin as NEXT_PUBLIC_API_URL, matching the live image.
PaulLaux
left a comment
There was a problem hiding this comment.
New issues:
The live site's own origin is blocked by the API:
server/api/server.js:256 (CORS allowlist) and server/api/server.js:309 (WebSocket allowlist).
the PR moves testnet to https://cipherscan.test-zsa.org for the site and https://cipherscan-api.test-zsa.org for the API. Both allowlists still name only upstream's hosts. We get 500 (CORS rejection). All live pages are currentl dead. See #7 for a fix - Merge/adopt.
This one is critical. please rebuild with the updated docker build config and redeploy both api and web after this fix.
Also, removing Redis breaks the API test suite in CI: server/api/test/list-cache.redis.test.js:26 still does require('redis'). Delete the test and remove the Redis service and TEST_REDIS_URL from ci.yml. Then point the CI triggers at zsa1.
Think that's the minimum
Allow the ZSA site origin and route the WebSocket through /api
Merged #7, rebuilt and redeployed api and web (hash 669a97b), and the live site works. |
PaulLaux
left a comment
There was a problem hiding this comment.
looks better, Please update pr description and fix ci before merge.
78b50d4 to
640aca9
Compare