Skip to content

Add cadmus - #1207

Open
qiskit-bot wants to merge 20 commits into
mainfrom
submission-44da023a
Open

qiskit-bot wants to merge 20 commits into
mainfrom
submission-44da023a

Conversation

@qiskit-bot

Copy link
Copy Markdown
Collaborator

Nomination for: cadmus

By cogu92, via #1206

Co-authored-by: cogu92 <cogu92@users.noreply.github.com>
@qiskit-bot qiskit-bot added the submission Project submission label Jun 29, 2026
Comment thread resources/members/cadmus_44da023a.toml Outdated
Comment thread resources/members/cadmus_44da023a.toml Outdated
@CLAassistant

CLAassistant commented Jul 2, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@1ucian0
Luciano Bello (1ucian0) marked this pull request as ready for review July 2, 2026 10:26

@1ucian0 Luciano Bello (1ucian0) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GitHub could not detect your license. Maybe something to take a look there?

owner = "cogu92"
repo = "cadmus"
stars = 0
license = "Other"

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i just add a license

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update in #1246 . However, the entry is fetched from GitHub and set automatically. Try to convince GH about the lincense... it it gets too complicated, we can do it manually, no worries.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
license = "Other"
license = "Other"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@1ucian0 Luciano Bello (1ucian0) Aug 20, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apache 2.0 should be here.

Image

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GitHub is now detecting the license correctly — the Community Standards checklist for cadmus shows License ✅, and https://github.com/cogu92/cadmus/license serves the full Apache-2.0 text (the earlier copy was truncated, which is why GH couldn't recognize it).

Could you re-run the validation, or would it help if I set license = "Other" to license = "Apache-2.0" manually in the toml?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indeed, github detects A license, but it does not detect it is Apache.

@1ucian0 Luciano Bello (1ucian0) added the stale? If a PR/issue has this label, it will be closed after 30 days of inactivity label Aug 1, 2026
Comment thread resources/members/cadmus_44da023a.toml Outdated
owner = "cogu92"
repo = "cadmus"
stars = 0
license = "Other"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i just add a license

owner = "cogu92"
repo = "cadmus"
stars = 0
license = "Other"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
license = "Other"
license = "Other"

owner = "cogu92"
repo = "cadmus"
stars = 0
license = "Other"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@1ucian0 Luciano Bello (1ucian0) removed the stale? If a PR/issue has this label, it will be closed after 30 days of inactivity label Aug 20, 2026
owner = "cogu92"
repo = "cadmus"
stars = 0
license = "Other"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GitHub is now detecting the license correctly — the Community Standards checklist for cadmus shows License ✅, and https://github.com/cogu92/cadmus/license serves the full Apache-2.0 text (the earlier copy was truncated, which is why GH couldn't recognize it).

Could you re-run the validation, or would it help if I set license = "Other" to license = "Apache-2.0" manually in the toml?

@Qiskit Qiskit (Qiskit) deleted a comment from github-actions Bot Aug 27, 2026
@1ucian0

Copy link
Copy Markdown
Member

GitHub still detect Other:

$ python manager.py members update_github 44da023a 
2026-08-27 14:50:01 ecosystem INFO Updating cadmus_44da023a: github.license ( -> Other)

@1ucian0

Copy link
Copy Markdown
Member

There are several differences between your LICENSE file and the Apache License. Check them here. I suggest you copy the LICENSE file from scratch and change the copyright information again.

@1ucian0 Luciano Bello (1ucian0) added the stale? If a PR/issue has this label, it will be closed after 30 days of inactivity label Sep 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stale? If a PR/issue has this label, it will be closed after 30 days of inactivity submission Project submission

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants