Add cadmus - #1207
Add cadmus#1207qiskit-bot wants to merge 20 commits into
Conversation
Co-authored-by: cogu92 <cogu92@users.noreply.github.com>
Luciano Bello (1ucian0)
left a comment
There was a problem hiding this comment.
GitHub could not detect your license. Maybe something to take a look there?
| owner = "cogu92" | ||
| repo = "cadmus" | ||
| stars = 0 | ||
| license = "Other" |
There was a problem hiding this comment.
It seems like GitHub is not detecting the license in your repo. Have a look to https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/licensing-a-repository#detecting-a-license
There was a problem hiding this comment.
Thanks for the update in #1246 . However, the entry is fetched from GitHub and set automatically. Try to convince GH about the lincense... it it gets too complicated, we can do it manually, no worries.
There was a problem hiding this comment.
| license = "Other" | |
| license = "Other" |
There was a problem hiding this comment.
GitHub is now detecting the license correctly — the Community Standards checklist for cadmus shows License ✅, and https://github.com/cogu92/cadmus/license serves the full Apache-2.0 text (the earlier copy was truncated, which is why GH couldn't recognize it).
Could you re-run the validation, or would it help if I set license = "Other" to license = "Apache-2.0" manually in the toml?
There was a problem hiding this comment.
indeed, github detects A license, but it does not detect it is Apache.
| owner = "cogu92" | ||
| repo = "cadmus" | ||
| stars = 0 | ||
| license = "Other" |
| owner = "cogu92" | ||
| repo = "cadmus" | ||
| stars = 0 | ||
| license = "Other" |
There was a problem hiding this comment.
| license = "Other" | |
| license = "Other" |
| owner = "cogu92" | ||
| repo = "cadmus" | ||
| stars = 0 | ||
| license = "Other" |
| owner = "cogu92" | ||
| repo = "cadmus" | ||
| stars = 0 | ||
| license = "Other" |
There was a problem hiding this comment.
GitHub is now detecting the license correctly — the Community Standards checklist for cadmus shows License ✅, and https://github.com/cogu92/cadmus/license serves the full Apache-2.0 text (the earlier copy was truncated, which is why GH couldn't recognize it).
Could you re-run the validation, or would it help if I set license = "Other" to license = "Apache-2.0" manually in the toml?
|
GitHub still detect |
|
There are several differences between your LICENSE file and the Apache License. Check them here. I suggest you copy the LICENSE file from scratch and change the copyright information again. |

Nomination for: cadmus
By cogu92, via #1206