fix(settings): refresh language row labels on live locale switch - #39
Merged
Conversation
Obsidian's declarative reconciler re-renders every settings row except the one whose control triggered the change, so after switching the display language the language row kept the previous locale's name and description until the tab was reopened. Patch the row's leaf text nodes directly after update(); any later full render produces the same strings, so this cannot conflict with the reconciler. Co-authored-by: QoderAI (Qwen 3.8 Max) <qoder_ai@qoder.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
setControlValue('locale')persists and callsupdate(), the tab now also patches the language row's leaf text nodes directly with the new locale's strings. Any later full render produces the same strings, so this cannot conflict with the reconciler.renderLegacySettings().querySelectorAllto the mockedPluginSettingTab.containerEland a CHANGELOG entry; ignores the.verify-shots/scratch dir.Verification
npm run typechecknpm run lintnpm run test(3411 tests)npm run buildnpm run release:checkSafety
CHANGELOG.md