Adopt quantecon/actions/publish-gh-pages for GitHub Pages deploy#568
Open
mmcky wants to merge 2 commits into
Open
Adopt quantecon/actions/publish-gh-pages for GitHub Pages deploy#568mmcky wants to merge 2 commits into
mmcky wants to merge 2 commits into
Conversation
Replaces the hand-rolled Pages deploy (configure-pages + upload-pages-artifact + deploy-pages) and inline release-asset packaging (tar/sha256/manifest -> softprops/action-gh-release) with a single quantecon/actions/publish-gh-pages@v0.8.0 step, matching the rest of the lecture family. Deploy-step only: the build, notebook sync, PDF/notebook and Netlify steps are unchanged. Part of QuantEcon/lectures#11. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR migrates the repository’s GitHub Pages deployment workflow to use the shared quantecon/actions/publish-gh-pages@v0.8.0 composite action, aligning the deploy/release-asset publishing approach with the rest of the QuantEcon lecture repositories.
Changes:
- Replace the hand-rolled release-asset packaging + GitHub Pages deploy steps with a single
quantecon/actions/publish-gh-pages@v0.8.0step (includingcnameand release-asset creation). - Update the GitHub Pages environment URL to read from the deploy step’s output.
steps.deployment.outputs['page-url'] is the robust form for a hyphenated output key; addresses Copilot review feedback. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrates the GitHub Pages deploy to
quantecon/actions/publish-gh-pages@v0.8.0, bringing this repo onto the same publish action as the rest of the lecture family. Part of the standardization tracked in QuantEcon/lectures#11.What changed
One composite step replaces six hand-rolled steps — the inline release-asset packaging (
tar+sha256sum+manifest.json→softprops/action-gh-release) and the native Pages deploy (configure-pages→upload-pages-artifact→deploy-pages):uses: quantecon/actions/publish-gh-pages@v0.8.0withbuild-dir,cname: python-programming.quantecon.org,create-release-assets: 'true',asset-name,github-token.environment.urlnow reads the composite's output name (page-url).Scope — deploy only, no build change
The
jb buildsteps (nitpick flags intact), the PDF/notebook asset builds, and the notebook sync tolecture-python-programming.notebooksare untouched. This is the same deploy-step swap the five composite repos already run in production, so the build-behavior differences don't apply here.Behavioral notes
lecture-python-programming-html-<tag>.tar.gz). The checksum/manifest filenames change from the fixedhtml-checksum.txt/html-manifest.jsontolecture-python-programming-html-checksum.txt/-manifest.json, and the manifest gainsname+repositoryfields — matching the convention the other repos already use.publish*tag after merge.References: publish-gh-pages@v0.8.0