Skip to content

Reverse/forward Enzyme rules, refactoring, and tests for planar ops - #474

Merged
kshyatt merged 6 commits into
mainfrom
ksh/enz_planar
Jul 29, 2026
Merged

Reverse/forward Enzyme rules, refactoring, and tests for planar ops#474
kshyatt merged 6 commits into
mainfrom
ksh/enz_planar

Conversation

@kshyatt

@kshyatt kshyatt commented Jul 6, 2026

Copy link
Copy Markdown
Member

No description provided.

@codecov

codecov Bot commented Jul 7, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 29.41176% with 12 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
ext/TensorKitEnzymeExt/utility.jl 7.69% 12 Missing ⚠️
Files with missing lines Coverage Δ
ext/TensorKitEnzymeExt/linalg.jl 74.01% <100.00%> (+0.88%) ⬆️
ext/TensorKitMooncakeExt/TensorKitMooncakeExt.jl 100.00% <ø> (ø)
ext/TensorKitMooncakeExt/utility.jl 100.00% <ø> (ø)
src/TensorKit.jl 17.24% <ø> (ø)
ext/TensorKitEnzymeExt/utility.jl 20.93% <7.69%> (-0.70%) ⬇️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kshyatt
kshyatt force-pushed the ksh/enz_planar branch 2 times, most recently from 2559062 to 239ac56 Compare July 13, 2026 11:12
@kshyatt

kshyatt commented Jul 27, 2026

Copy link
Copy Markdown
Member Author

Marking FusionTreeDict inactive seems to have helped, now the errors are all in the situation of the more complex braidings. Time to investigate more 🤓

@kshyatt kshyatt changed the title Reverse Enzyme rules, refactoring, and tests for planar ops Reverse/forward Enzyme rules, refactoring, and tests for planar ops Jul 27, 2026
@kshyatt

kshyatt commented Jul 28, 2026

Copy link
Copy Markdown
Member Author

OK so some digging seems to show the error for VfHubbard and VRepA4Twistedℤ₄ is arising from the coefficient * alpha going into tensortrace!, a path that is only reached for these more complicated spaces. I've tried a bunch of things -- caching doesn't seem to be the culprit -- but still pretty mystified. Basically, it seems one subblock is getting the wrong coefficient on the reverse pass. If anyone has any ideas, chime in!

@kshyatt
kshyatt force-pushed the ksh/enz_planar branch 2 times, most recently from b55b70f to b61bcaf Compare July 28, 2026 13:23
@kshyatt
kshyatt requested a review from lkdvos July 28, 2026 13:23
@kshyatt
kshyatt marked this pull request as ready for review July 29, 2026 09:27
lkdvos
lkdvos reviewed Jul 29, 2026
View reviewed changes

@lkdvos lkdvos left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments, but otherwise this looks llike a nice cleanup!

Comment thread ext/TensorKitEnzymeExt/linalg.jl Outdated
Comment thread ext/TensorKitEnzymeExt/linalg.jl Outdated
Comment thread ext/TensorKitEnzymeExt/utility.jl Outdated
Comment thread ext/TensorKitEnzymeExt/utility.jl
lkdvos
lkdvos reviewed Jul 29, 2026
View reviewed changes
Comment thread ext/TensorKitEnzymeExt/linalg.jl
lkdvos
lkdvos approved these changes Jul 29, 2026
View reviewed changes

@lkdvos lkdvos left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will already approve, but have 1 final comment left

@kshyatt
kshyatt enabled auto-merge (squash) July 29, 2026 17:05
@kshyatt
kshyatt merged commit e852e6a into main Jul 29, 2026
100 of 101 checks passed
@kshyatt
kshyatt deleted the ksh/enz_planar branch July 29, 2026 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lkdvos lkdvos lkdvos approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kshyatt @lkdvos