fix: gate mobile home swap behind FeatureFlags.showSwapButton (off); build 131 - #630
Merged
Conversation
n13
force-pushed
the
fix/remove-swap-build-131
branch
from
September 3, 2026 09:22
7336431 to
cdec83e
Compare
n13
changed the title
…lag (off); build 131 App review needs swap gone, but we toggle it across builds. Keep the swap card behind a hardcoded flag in a new shared FeatureFlags class (lib/shared/constants/feature_flags.dart), set to false, so the home row shows Receive and Send; flip FeatureFlags.showSwapButton to true to bring swap back. Build number bumped to 131. The home actions test follows the flag.
n13
force-pushed
the
fix/remove-swap-build-131
branch
from
September 3, 2026 09:26
ba242ec to
a7da4d4
Compare
n13
changed the title
n13
commented
Sep 3, 2026
n13
left a comment
n13
left a comment
Collaborator
Author
There was a problem hiding this comment.
Reviewer model: GPT Sol
Verdict (advisory): Approve
No blocking findings.
The compile-time AppConstants.showSwapButton = false cleanly removes Swap from the regular-account home action row while preserving Receive and Send. Flipping the flag back to true reuses the existing Swap card, including its disabled state for encrypted accounts. The regular and multisig rows use the same 20 px gap, the activity typography changes use existing V3 theme tokens, and 1.5.12+131 matches the generated version constants.
Validation:
- Reviewed the complete
ae6c29b2...dc6222d0diff and surrounding home/button/theme code;git diff --checkpassed. - Changed Dart files pass
dart format --output=none --set-exit-if-changed --line-length=120. flutter test test/screens/home_intent_gating_test.dart: 5/5 passed locally.- Exact-head GitHub CI passed formatting, workspace analysis, all mobile tests, non-native SDK tests, and cold-wallet tests.
n13
added a commit
that referenced
this pull request
Sep 3, 2026
… (#631) * feat(ui): ActionCard widget for the home action tiles, per the app design The home Receive/Send/Swap tiles are not a design-system Button type: they use a vertical gradient fill, a hairline border, 20/16 padding and an icon-over-label layout. Add the two gradient stops as bgCardTop/bgCardBottom tokens, move the tile into a shared ActionCard widget, and drop the per-call QuantusButton overrides from the home screen. * refactor(ui): rename the tile gradient tokens to bgCardGradientTop/Bottom
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
App review needs the swap action gone from the mobile home, but we'll toggle it across builds. The swap card is gated behind a hardcoded feature flag rather than deleted.
Changes
FeatureFlagsclass — newmobile-app/lib/shared/constants/feature_flags.dart(following theE2EKeysconvention) holdsshowSwapButton, currentlyfalse. While false, the home row shows Receive and Send. FlipFeatureFlags.showSwapButtontotrueto bring the swap button back next build. The swap card, itsSwapScreenimport, and the disabled-for-encrypted behavior stay in place behind the flag.1.5.12+130→1.5.12+131inpubspec.yaml,version.g.dartregenerated viatool/generate_version.sh.home_intent_gating_test.dartasserts Receive and Send always show and Swap followsFeatureFlags.showSwapButton, so it stays correct whichever way the flag is set.Verification
melos analyzeclean across all packages.