Fix format check and pin the rustfmt nightly - #148
Merged
Conversation
Nightly rustfmt 2026-08-30 wraps two long trailing comments, breaking the unpinned +nightly format check on main for every PR. Moves both comments onto their own lines and pins rustfmt to nightly-2026-08-31 in the ubuntu/ macos setup actions, ci.yml and the release workflow, so formatting rules only change when the pin is bumped.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
cargo +nightly fmt --checkgate fails onmainsince nightly 2026-08-30 started wrapping long trailing comments — the same drift already fixed in qp-rusty-crystals#120. It currently fails CI on every PR (#146, #147) in files those PRs don't touch.src/cli/cold_signing.rs:606,src/cli/wormhole.rs:4349) onto their own lines, stable across rustfmt versions.nightly-2026-08-31in theubuntu/macossetup actions,ci.yml, andcreate-release-tag-and-publish.yml— one bump point per file, same approach as rusty-crystals.Unblocks #146 and #147 (rebase/re-run after this merges) and the next CLI release.