Skip to content

[GRDM-63377] ストレージ一覧のページネーション対応に伴うユニットテストの修正 #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
yacchin1205 wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

[GRDM-63377] ストレージ一覧のページネーション対応に伴うユニットテストの修正 #7

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2cb8392
Fix pagination metadata in storage response mocks
yacchin1205 Oct 27, 2026
8d97a18
Build MinIO images from source for E2E tests
yacchin1205 Oct 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions .github/workflows/e2e-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,15 @@ jobs:
-f docker/elasticsearch/Dockerfile.amd64 docker/elasticsearch
echo 'ELASTICSEARCH_IMAGE=elasticsearch-kuromoji:e2e' >> "$GITHUB_ENV"

- name: Build MinIO images from source
if: matrix.storage.minio_enabled == 'true'
working-directory: e2e-test/resources
run: |
docker build -t minio-source:local -f docker/minio/Dockerfile.minio docker/minio
docker build -t minio-mc-source:local -f docker/minio/Dockerfile.mc docker/minio
echo 'MINIO_IMAGE=minio-source:local' >> "$GITHUB_ENV"
echo 'MINIO_MC_IMAGE=minio-mc-source:local' >> "$GITHUB_ENV"

- name: Generate MinIO credentials
if: matrix.storage.minio_enabled == 'true'
run: |
Expand Down
2 changes: 1 addition & 1 deletion e2e-test/resources
Open in desktop
Submodule resources updated 8 files
+91 −36 .github/workflows/e2e-test.yml
+15 −0 docker/minio/Dockerfile.mc
+15 −0 docker/minio/Dockerfile.minio
+32 −18 scripts/grdm.py
+3 −0 scripts/playwright.py
+7 −2 テスト手順-Workflowアドオン-公開範囲の設定.ipynb
+35 −21 テスト手順-Workflowアドオン-有効化・無効化.ipynb
+7 −2 テスト手順-Workflowアドオン-自動有効化.ipynb
4 changes: 2 additions & 2 deletions rdmfs/tests/test_inode.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,7 @@ async def test_list_all_projects_creates_virtual_root():
response_linked_meta.json.return_value = linked_metadata_payload
storage_response = MagicMock()
storage_response.status_code = 200
storage_response.json.return_value = {'data': []}
storage_response.json.return_value = {'data': [], 'links': {'next': None}}
mock_osf.session.get = AsyncMock(return_value=storage_response)

responses = [
Expand Down Expand Up @@ -310,7 +310,7 @@ async def test_list_all_projects_handles_pagination():

storage_response = MagicMock()
storage_response.status_code = 200
storage_response.json.return_value = {'data': []}
storage_response.json.return_value = {'data': [], 'links': {'next': None}}
mock_osf.session.get = AsyncMock(return_value=storage_response)
mock_osf._get = AsyncMock(side_effect=[response_page1, response_page2, response_meta1, response_meta2])
mock_osf._json = MagicMock(side_effect=lambda resp, status: resp.json())
Expand Down
Loading