Skip to content

SM8250: add RP5 and Flip 2 Visionox display refresh rate calibration - #3523

Merged
spycat88 merged 1 commit into
ROCKNIX:nextfrom
MagnominusGit:rp5-visionox-panel-calibration-pr
Oct 25, 2026
Merged

spycat88 merged 1 commit into
ROCKNIX:nextfrom
MagnominusGit:rp5-visionox-panel-calibration-pr

Conversation

@MagnominusGit

@MagnominusGit MagnominusGit commented Oct 16, 2026 •

Copy link
Copy Markdown
Contributor

Summary

What does this PR do?

Adds display refresh rate calibration to Retroid Pocket 5 and Flip 2 units with the Visionox VTDR6130 panel, the same as #3484 does for the RP6.

  • These units use the RP6's panel init sequence and 60/120 Hz modes through SM8250's copy of the driver (0104 + 0105). Patch 0506 adds the same frame_len_120/frame_len_60 nodes as SM8550 0508, unchanged.
  • The RP5 quirk folder is shared by the RP5, Flip 2 and both Visionox variants, so the quirk exits when the panel has no frame_len_60 node. Only Visionox units get the ES entry and the saved values at boot.

Testing & Verification

Test Steps

  1. On a Visionox unit, run System Settings > System Management and Reset > Calibrate Display Refresh Rate.
  2. Measure the panel's refresh rate (DRM vblank timestamps) at 60 Hz and 120 Hz with the stock and the calibrated frame lengths.
  3. Reboot and check that the saved values are applied again.

Test Results & Evidence

Stock Calibrated
120 Hz frame length 0x1C 0x14
60 Hz frame length 0x7D0 0x7BC
120 Hz mode 119.552 Hz 120.029 Hz
60 Hz mode 59.707 Hz 60.013 Hz

The saved 60 Hz value was applied again after a reboot.


Additional Context & Reviewer Notes

The quirk uses the fixed ae94000.dsi.0 path and frame_len_60, as suggested in #3484. The calibration script and ES entry are unchanged.


AI Assistance Disclosure

While ROCKNIX has no restrictions on using AI tools, transparency helps reviewers set the proper context during code review.

Did you use AI tools (e.g., ChatGPT, Copilot, Claude) to assist with this pull request?

  • No Written entirely without AI tools.
  • Partially AI was used for minor assistance (e.g., refactoring, writing tests, debugging, documentation).
  • Yes AI generated a major portion of the code or implementation.

@MagnominusGit
MagnominusGit marked this pull request as ready for review October 17, 2026 00:16
@spycat88
spycat88 added this pull request to the merge queue Oct 25, 2026
Merged via the queue into ROCKNIX:next with commit 55229ad Oct 25, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants