Repository navigation
[fix][CI] Run aiter's install_triton.sh to match aiter's Triton version - #1300
Merged
Merged
Conversation
aiter PR #4968 (aebb813) introduced a `_load_kv` helper with a `cache_modifier: gl.constexpr = ""` parameter that requires Triton 3.8.0. FlyDSL CI was using the Docker image's built-in Triton (older than 3.8.0), causing `AttributeError: 'str' object has no attribute 'type'` in `pa_decode_gluon.py`. Run aiter's own `install_triton.sh` so our CI uses the same Triton version aiter is tested against. Co-Authored-By: Claude <noreply@anthropic.com>
jli-melchior
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
aiter introduced a
_load_kvhelper with acache_modifier: gl.constexpr = ""parameter that requires Triton 3.8.0. FlyDSL CI was using the Docker image's built-in Triton (older than 3.8.0), causingAttributeError: 'str' object has no attribute 'type'inpa_decode_gluon.py. Run aiter's owninstall_triton.shso our CI uses the same Triton version aiter is tested against.Motivation
Technical Details
Test Plan
Test Result
Submission Checklist