[OMPT] Update veccopy EMI/non-EMI tests - #2481
Merged
Merged
Conversation
This updates the downstream test to changes that came in through the merges.
jplehr
requested review from
carlobertolli,
estewart08,
gregrodgers,
ronlieb and
zGoldthorpe
as code owners
August 31, 2026 13:20
ronlieb
approved these changes
Aug 31, 2026
mhalk
reviewed
Aug 31, 2026
mhalk
left a comment
mhalk
left a comment
Collaborator
There was a problem hiding this comment.
Minor issue which is not blocking but should IMHO be addressed.
If that's also upstream, we should fix that, too.
| /// CHECK: Callback DataOp EMI: endpoint=2 optype=4 | ||
| /// CHECK: Callback Target EMI: kind=1 endpoint=2 | ||
| /// CHECK: Callback Target EMI: kind=1 endpoint=1 | ||
| /// CHECK: Callback Target: target_id=[[TARGET_ID:[0-9]+]] kind=1 endpoint=2 |
Collaborator
There was a problem hiding this comment.
Q: Is this re-definiton on purpose?
Otherwise, IMHO we should replace the corresponding (total: 4) definitions, following kind=1 endpoint=1, with uses like this:
Suggested change
| /// CHECK: Callback Target: target_id=[[TARGET_ID:[0-9]+]] kind=1 endpoint=2 | |
| /// CHECK: Callback Target: target_id=[[TARGET_ID]] kind=1 endpoint=2 |
| /// CHECK: Callback DataOp EMI: endpoint=2 optype=1 | ||
| /// CHECK: Callback DataOp EMI: endpoint=1 optype=2 | ||
| /// CHECK: Callback DataOp EMI: endpoint=2 optype=2 | ||
| /// CHECK: Callback Submit: target_id=[[TARGET_ID:[0-9]+]] host_op_id=[[HOST_OP_ID:[0-9]+]] req_num_teams=1 |
| /// CHECK: Callback DataOp EMI: endpoint=2 optype=1 | ||
| /// CHECK: Callback DataOp EMI: endpoint=1 optype=2 | ||
| /// CHECK: Callback DataOp EMI: endpoint=2 optype=2 | ||
| /// CHECK: Callback Submit: target_id=[[TARGET_ID:[0-9]+]] host_op_id=[[HOST_OP_ID:[0-9]+]] req_num_teams=0 |
| /// CHECK: Callback DataOp EMI: endpoint=1 optype=4 | ||
| /// CHECK: Callback DataOp EMI: endpoint=2 optype=4 | ||
| /// CHECK: Callback Target EMI: kind=1 endpoint=2 | ||
| /// CHECK: Callback Target: target_id=[[TARGET_ID:[0-9]+]] kind=1 endpoint=2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates a downstream test to changes upstream.
Upstream also has this test (basically), so we will converge to remove the downstream-only test at some point.