Repository navigation
Require clang-tidy 19 or later, and rename CLANG_TIDY_EXE - #252
Merged
Merged
Conversation
HIPOBJ_USE_CLANG_TIDY now rejects a clang-tidy older than 19, which can't read .clang-tidy, and fails to configure rather than warning when it finds none. It searches PATH for clang-tidy and versioned names (newest first) before falling back to ROCm's, which lacks the clang-analyzer-* checks. The variable that selects it is now HIPOBJ_CLANG_TIDY_EXE. Co-Authored-By: Claude <noreply@anthropic.com>
derobins
requested review from
akolliasAMD,
gaoikawa,
jordan-turbofish,
kurtmcmillan,
riley-dixon,
sbates130272 and
zbyrne
as code owners
October 17, 2026 22:28
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
Version validation, discovery, and updated references are consistent, with no unresolved findings.
No open issues 🎉
What changed in this PR
This PR makes hipObject’s clang-tidy configuration fail early when a compatible tool is unavailable.
Changes:
- Require clang-tidy 19 or later and validate discovered or explicitly selected executables.
- Search unversioned and versioned names before the ROCm fallback.
- Rename the selector to
HIPOBJ_CLANG_TIDY_EXEand update CI and documentation.
| File | Description |
|---|---|
| docs/building.rst | Documents discovery order and the renamed selector. |
| cmake/HIPOBJClangTidy.cmake | Adds version validation, discovery, and configuration errors. |
| CHANGELOG.md | Records the requirement and variable rename. |
| AGENTS.md | Updates clang-tidy selection guidance. |
| .github/workflows/hipobject-clang-tidy.yml | Uses the renamed selector in CI. |
Review effort: Balanced
Contributor
Security scan found no critical or high findings on lines changed by this pull requestView the security scan run for complete reports. “New” means the finding is located in a changed file on an added or modified line; it is not a base-versus-head findings delta. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HIPOBJ_USE_CLANG_TIDY now rejects a clang-tidy older than 19, which can't read .clang-tidy, and fails to configure rather than warning when it finds none. It searches PATH for clang-tidy and versioned names (newest first) before falling back to ROCm's, which lacks the clang-analyzer-* checks. The variable that selects it is now HIPOBJ_CLANG_TIDY_EXE.