Skip to content

Clean up small CMake issues - #261

Merged
derobins merged 1 commit into
developfrom
derobins/cmake_tweaks
Oct 19, 2026
Merged

derobins merged 1 commit into
developfrom
derobins/cmake_tweaks

Conversation

@derobins

Copy link
Copy Markdown
Collaborator
  • Add a hipobj::hipobj ALIAS, so a project that adds hipObject with add_subdirectory() or FetchContent can link the library by the installed package's name. The subproject test checks for it.
  • Don't install a downloaded GoogleTest (INSTALL_GTEST OFF). Its install rules have no component, so cmake --install put it in hipObject's prefix.
  • Require OpenSSL 3 for the MinIO bridge, and remove the OpenSSL 1.1 package dependency branch, which no supported platform reaches.
  • Remove the redundant BUILD_TESTING check in test/CMakeLists.txt and the redundant include of HIPOBJUseGTest.cmake in the MinIO bridge's tests.
  • Remove test/common/test-common.h, which nothing includes.
  • Fix hipobj_add_test()'s comment, which mentioned seam swaps that no longer exist.

- Add a hipobj::hipobj ALIAS, so a project that adds hipObject with
  add_subdirectory() or FetchContent can link the library by the
  installed package's name. The subproject test checks for it.
- Don't install a downloaded GoogleTest (INSTALL_GTEST OFF). Its install
  rules have no component, so cmake --install put it in hipObject's
  prefix.
- Require OpenSSL 3 for the MinIO bridge, and remove the OpenSSL 1.1
  package dependency branch, which no supported platform reaches.
- Remove the redundant BUILD_TESTING check in test/CMakeLists.txt and
  the redundant include of HIPOBJUseGTest.cmake in the MinIO bridge's
  tests.
- Remove test/common/test-common.h, which nothing includes.
- Fix hipobj_add_test()'s comment, which mentioned seam swaps that no
  longer exist.

Co-Authored-By: Claude <noreply@anthropic.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

Static review found no blocking issues in these small, focused changes; builds and tests were not run.

No open issues 🎉

What changed in this PR

This PR simplifies hipObject’s CMake setup and improves consistency between embedded builds and installed packages.

Changes:

  • Adds the hipobj::hipobj alias and checks its availability in subproject builds.
  • Prevents downloaded GoogleTest from being installed and requires OpenSSL 3 or later for the MinIO bridge.
  • Removes redundant test setup and an unused header, and updates comments and changelog entries.
File Description
test/​subproject/​parent/​CMakeLists.txt Checks that the namespaced alias exists.
test/​common/​test-common.h Removes an unused test header.
test/​CMakeLists.txt Removes a redundant testing condition.
src/​CMakeLists.txt Adds the hipobj::hipobj alias.
integrations/​minio-cpp/​test/​CMakeLists.txt Removes a redundant GoogleTest setup include.
integrations/​minio-cpp/​CMakeLists.txt Removes OpenSSL 1.1 package dependency handling.
cmake/​HIPOBJUseGTest.cmake Disables GoogleTest installation and corrects a comment.
cmake/​HIPOBJMinioCppDeps.cmake Requires OpenSSL 3 or later.
CHANGELOG.md Documents user-facing build and installation changes.

Review effort: Balanced

@github-actions

Copy link
Copy Markdown
Contributor
Security scan found no critical or high findings on lines changed by this pull request

View the security scan run for complete reports.

“New” means the finding is located in a changed file on an added or modified line; it is not a base-versus-head findings delta.

@derobins
derobins merged commit bc1e5c1 into develop Oct 19, 2026
41 checks passed
@derobins
derobins deleted the derobins/cmake_tweaks branch October 19, 2026 05:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants