Repository navigation
Clean up small CMake issues - #261
Merged
Merged
Conversation
derobins
commented
Oct 19, 2026
Collaborator
- Add a hipobj::hipobj ALIAS, so a project that adds hipObject with add_subdirectory() or FetchContent can link the library by the installed package's name. The subproject test checks for it.
- Don't install a downloaded GoogleTest (INSTALL_GTEST OFF). Its install rules have no component, so cmake --install put it in hipObject's prefix.
- Require OpenSSL 3 for the MinIO bridge, and remove the OpenSSL 1.1 package dependency branch, which no supported platform reaches.
- Remove the redundant BUILD_TESTING check in test/CMakeLists.txt and the redundant include of HIPOBJUseGTest.cmake in the MinIO bridge's tests.
- Remove test/common/test-common.h, which nothing includes.
- Fix hipobj_add_test()'s comment, which mentioned seam swaps that no longer exist.
- Add a hipobj::hipobj ALIAS, so a project that adds hipObject with add_subdirectory() or FetchContent can link the library by the installed package's name. The subproject test checks for it. - Don't install a downloaded GoogleTest (INSTALL_GTEST OFF). Its install rules have no component, so cmake --install put it in hipObject's prefix. - Require OpenSSL 3 for the MinIO bridge, and remove the OpenSSL 1.1 package dependency branch, which no supported platform reaches. - Remove the redundant BUILD_TESTING check in test/CMakeLists.txt and the redundant include of HIPOBJUseGTest.cmake in the MinIO bridge's tests. - Remove test/common/test-common.h, which nothing includes. - Fix hipobj_add_test()'s comment, which mentioned seam swaps that no longer exist. Co-Authored-By: Claude <noreply@anthropic.com>
derobins
requested review from
akolliasAMD,
gaoikawa,
jordan-turbofish,
kurtmcmillan,
riley-dixon,
sbates130272 and
zbyrne
as code owners
October 19, 2026 05:08
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
Static review found no blocking issues in these small, focused changes; builds and tests were not run.
No open issues 🎉
What changed in this PR
This PR simplifies hipObject’s CMake setup and improves consistency between embedded builds and installed packages.
Changes:
- Adds the
hipobj::hipobjalias and checks its availability in subproject builds. - Prevents downloaded GoogleTest from being installed and requires OpenSSL 3 or later for the MinIO bridge.
- Removes redundant test setup and an unused header, and updates comments and changelog entries.
| File | Description |
|---|---|
| test/subproject/parent/CMakeLists.txt | Checks that the namespaced alias exists. |
| test/common/test-common.h | Removes an unused test header. |
| test/CMakeLists.txt | Removes a redundant testing condition. |
| src/CMakeLists.txt | Adds the hipobj::hipobj alias. |
| integrations/minio-cpp/test/CMakeLists.txt | Removes a redundant GoogleTest setup include. |
| integrations/minio-cpp/CMakeLists.txt | Removes OpenSSL 1.1 package dependency handling. |
| cmake/HIPOBJUseGTest.cmake | Disables GoogleTest installation and corrects a comment. |
| cmake/HIPOBJMinioCppDeps.cmake | Requires OpenSSL 3 or later. |
| CHANGELOG.md | Documents user-facing build and installation changes. |
Review effort: Balanced
Contributor
Security scan found no critical or high findings on lines changed by this pull requestView the security scan run for complete reports. “New” means the finding is located in a changed file on an added or modified line; it is not a base-versus-head findings delta. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.