[CI] Parity: replace ROCm nightly with scheduled Preview - #3554
Merged
Conversation
Use the live rocm-preview mi350 topology and remove the retired nightly CLI/config key on the current develop history.
This was referenced Aug 11, 2026
Match the unique rocm-preview lane without pinning its OS, Python, or runner suffix so routine upstream renames do not disable auto-parity.
ethanwee1
requested review from
jataylo,
jeffdaily,
jithunnair-amd and
pruthvistony
as code owners
August 11, 2026 19:33
Use the restored eight-shard default matrix so parity downloads every live MI300 shard.
jithunnair-amd
pushed a commit
that referenced
this pull request
Aug 25, 2026
## Summary - classify Triton kernel, Triton heuristic, and fused-attention tests as PT2.0 - Inductor - classify backend skips, including TVM coverage, as PT2.0 - Dynamo - classify the new `hipSOLVER DnXsytrs requires ROCm >= 7.14` guard as hipSolver/Magma - support both dotted and slash-separated test file names ## Dashboard analysis Reviewed the AI analysis generated on 2026-08-04. It confirms that the `inductor.test_triton_heuristics` and TVM backend movements are classifier artifacts addressed by this PR. I also checked the underlying analyzed mi350 report rather than relying only on the AI recommendations: all 62 incoming unclassified skips are now covered—60 hipSOLVER version guards and two `inductor.test_fused_attention` tests. The analysis also reports large historical convolution, distributed, FSDP, and Misc category movements, but explicitly identifies them as unrelated collection/classifier churn and does not provide test-level evidence for a new category rule. This PR does not add speculative broad rules for those movements. This PR was split from the earlier parity automation stack and contains only skip-reason classification changes. ## Test plan - [x] Run Python syntax, lint, and whitespace checks - [x] Run the classifier against the analyzed mi350 parity CSV - [x] Confirm coverage rises from 62 unclassified skips to 0 (100% of 2,877 target tests classified) - [x] Verify this PR changes only `auto_classify_skip_reasons.py` ## Consolidated classifier coverage This PR now consolidates #3410 and #3456 in addition to its original Triton/TVM, DnXsytrs, and fused-attention rules. Added coverage includes conv2d backward, hipSOLVER xgeev, ROCm 6.4 linalg regressions, CUPTI profiler tests, block_table, explicit NVIDIA-only tests, and issue-linked `skipIfRocm` messages. Validation: Python compilation plus eight focused regression cases spanning the consolidated and existing rules. The result is a strict superset of the fork classifier. ## Alignment landing order Independent of #3554 and safe to land after the downloader/link foundations. It supersedes closed #3410 and #3456 and is the consolidated classifier target. ## August 25 refresh - Merged current ROCm `develop`. - Recognize both `Need at least 4 CUDA devices` and `Need at least 4 accelerator devices` as `Greater than 4 GPU`. - Added and passed a focused regression test for both message forms.
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
nightlyparity key withpreviewrocm-previewlinux-noble-rocm-preview-py3.12-mi350jobsThis clean replacement is based on current
develop; it supersedes #3406, whose pre-reset history cannot merge without a force-push or unrelated-history merge.Test plan
download_testlogsparity.ymlas YAMLDependencies
Land this before the Preview auto-trigger update in #3555 and before retargeting the operational parity PRs.
Made with Cursor
Alignment landing order
This is the root dependency. After it lands, retarget the stacked PRs to
developin this order:Validation: full Preview run 31506711303 and combined Preview+MI350 run 31507307756 both succeeded on matching SHA
cf18dda7.August 25 refresh
Merged current ROCm
developand reran JSON, Python, and workflow YAML validation.The previously documented Preview and combined Preview+MI350 runs satisfy the end-to-end checklist item.