docs: refactor getting-started codelab to be based on sample app#10074
Merged
zspriggs merged 12 commits intoJul 8, 2026
Conversation
Contributor
|
This also fixes RaspberryPiFoundation/blockly-samples#1752 |
1 task
maribethb
reviewed
Jul 2, 2026
maribethb
left a comment
maribethb
left a comment
Contributor
There was a problem hiding this comment.
Sorry it's a lot of comments but overall the structure is great and I've mostly suggested some wording changes or minor reorganization!
maribethb
approved these changes
Jul 7, 2026
| import * as Blockly from 'blockly/core'; | ||
| ``` | ||
|
|
||
| This codelab will go over generators in the [generate JavaScript code](/codelabs/getting-started/generate-javascript-code) step, but for now just note that generators will need to be imported separately, like so: |
Contributor
There was a problem hiding this comment.
It might be easier to just say "We'll learn how to import generators in step ##" and leave the actual import statement for then.
But I'm also not sure if they know what a generator is at this point, so maybe best to leave it off entirely?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The basics
The details
Proposed Changes