Repository navigation
AppImage starts again after an update - #73
Merged
Merged
Conversation
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After an update the new AppImage did not open (reported on Linux ARM).
The jpackage launcher on Linux sets
_JPACKAGE_LAUNCHERfor the JVM (LinuxLauncherLib.cpp). The new AppImage, started from the JVM, inherited it, so its launcher took itself for a restart of the JVM from within (setInitJvmFromCmdlineOnly), started the JVM without the application and ended.start()inInstallernow removes the variable before it starts a process; on macOSopenstarts with a fresh environment anyway, Windows ignores it.Reproduced with a temporary workflow on ubuntu-26.04-arm (removed again): a jpackage AppImage starting itself with the inherited environment printed the
javausage and exited with 1; without the variable the new process started and exited with 0.Since the update runs the code of the installed version, this works from the update after the next one (the beta that has this fix updating to the following one); the same holds for the renaming of #71.