Fix LaunchAndFocus: always close splash, return false on failure - #50
Open
goldorakiller wants to merge 1 commit into
Open
Conversation
Follow-up to review feedback on RetroBat-Official#48. - The black splash was only closed inside the success branch (esHandle != IntPtr.Zero && !isExternalLauncher). When the main window handle was never obtained - exclusive fullscreen, or EmulationStation exiting early - it stayed on screen for the whole wait. It is now closed unconditionally right after the (bounded) wait loop, with a finally block as a safety net if an exception is thrown earlier. CloseBlackSplash is idempotent, so the extra call is harmless. - The method returned true even when an exception was caught, so callers could not distinguish a successful launch from a failed one. The success return is now at the end of the try block and the catch returns false. The XML doc was updated to match the new contract.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to review feedback on #48.
The black splash was only closed inside the success branch (esHandle != IntPtr.Zero && !isExternalLauncher). When the main window handle was never obtained - exclusive fullscreen, or EmulationStation exiting early - it stayed on screen for the whole wait. It is now closed unconditionally right after the (bounded) wait loop, with a finally block as a safety net if an exception is thrown earlier. CloseBlackSplash is idempotent, so the extra call is harmless.
The method returned true even when an exception was caught, so callers could not distinguish a successful launch from a failed one. The success return is now at the end of the try block and the catch returns false. The XML doc was updated to match the new contract.