Repository navigation
fix: restart on macOS and Linux - #189
Open
notryanfraser wants to merge 1 commit into
Open
notryanfraser wants to merge 1 commit into
notryanfraser wants to merge 1 commit into
Conversation
- restartGame passed the relaunch script to /bin/sh without -c, so sh treated it as a filename and the game never came back on macOS/Linux - macOS relaunch resolved Rhythia.app/Contents instead of the .app - Quote paths passed to the shell Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
restartGame()passed the relaunch script to/bin/shwithout-c, soshtreated it as a filename and the game never came back on macOS/Linux. macOS also resolvedRhythia.app/Contentsinstead of the.app. Paths passed to the shell are quoted now.Adds a small
util.Platformhelper (app bundle path, shell quoting, wait-for-exit). The macOS self-update PR adds the same file, so the two merge cleanly in either order.Testing
Builds;
dotnet format --verify-no-changesanddotnet csharpier check .pass.Split out of #171 as requested.
AI usage
Done with Claude Code (Anthropic). I reviewed the changes.
🤖 Generated with Claude Code