Skip to content

fix(ui): correct a stale boot-order comment in the analytics test (RIG-2874) #1081

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
trunk-io merged 2 commits into from
Sep 11, 2026
Merged

fix(ui): correct a stale boot-order comment in the analytics test (RIG-2874) #1081

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
23220ea
fix(ui): correct a stale boot-order comment in the analytics test (RI…
rigel-mintaka Sep 11, 2026
6939ed5
fix(ui): tighten the boot-order comment to two lines (RIG-2874)
rigel-mintaka Sep 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions apps/ui/src/analytics/analytics.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -263,9 +263,8 @@ describe("$ai_trace_id stamping", () => {
});

test("a trace id arriving AFTER createAnalytics is picked up by a later capture", () => {
// The whole reason the source is a getter over a mutable slot: boot builds
// the transport before analytics, so the first trace id lands later. A
// read-once-at-construction regression would capture undefined forever.
// Boot builds analytics BEFORE the transport, so no trace id exists yet at
// construction; reading once here would capture undefined forever.
const fake = makeFake();
let current: string | undefined;
const analytics = createAnalytics(config, {
Expand Down
Loading