docs(ui): anchor the captureRequest citation by its thrown string (RIG-2874) - #1105
Merged
trunk-io[bot] merged 1 commit intoSep 11, 2026
Conversation
…G-2874) The record cited index.test.ts:87 for the always-throwing fetch, but the throw is at :93 and the rejects.toThrow() gate at :95. Line numbers in this record have drifted repo-wide, so this anchors on the thrown string instead, which cannot drift.
This was referenced Sep 11, 2026
feat(ui): export a composeBoot seam so the analytics/clients boot order is testable (RIG-2874)
#1096
Merged
rigel-mintaka
added this pull request to stack #1098
September 11, 2026 18:51
|
Compass engineering docs preview: https://compass-ui-rig-2874-record-c.compass-eng-docs.pages.dev Deployed from Changed pages: |
mattwilkinsonn
approved these changes
Sep 11, 2026
|
😎 Stack merged successfully - details. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Review fix for #1097, landed additively on top.
The finding
#1097's added prose cited
index.test.ts:87forcaptureRequest'salways-throwing fetch. That number is wrong: in
packages/compass-client/src/index.test.tsthe unconditional throw is at:93
and the
rejects.toThrow()gate at :95. The semantic claim was correct —verified at source — only the line number was off.
Why anchor on the string instead of fixing the number
The drift is not local to #1097. The record carries
index.test.ts:linecitations at six sites, and the same
:87/:89numbering already appears inthe base record (the non-Latin-1 case), so #1097 propagated a pre-existing
stale number rather than introducing a new one. Bumping
:87→:93wouldbe correct today and stale again on the next edit to that test file.
So this cites the thrown string, which is unique in the repo and cannot
drift:
The symbol name plus the quoted string is a recoverable anchor without a line
number.
Scope
Only the citation this stack introduced. The record's other five drifted line
citations are pre-existing and left alone — sweeping them is a separate
concern and belongs in its own change, not smuggled into a review fix.
Gates
bun tools/design-ledger-gate/index.ts— OK, 311 ledger rows, 132 recordheaders valid (rc=0)
moon run root:markdownlint— rc=0Diff is one file, 4 insertions / 4 deletions.
RIG-2874