docs(ui): dot-matrix glyph primitives and the ActivityBarItem split (RIG-3603) - #1172
Merged
Merged
Conversation
|
😎 Merged successfully - details. |
|
Compass engineering docs preview: https://compass-ux-3603-glyph-primit.compass-eng-docs.pages.dev Deployed from Changed pages: |
rigel-mintaka
force-pushed
the
compass-ux/3603-glyph-primitives-design
branch
from
September 12, 2026 20:32
98780ec to
122b0a5
Compare
rigel-mintaka
marked this pull request as ready for review
September 12, 2026 20:36
…RIG-3603)
Compass UI chrome depends on 29 non-ASCII glyphs that neither brand face
covers, held up by a ~14 MB Unifont pin in the e2e toolchain. This record
adopts the dot-matrix `crispEdges` SVG technique DL-150/DL-199 already froze
and shipped in `StateDot`/`BadgeGlyph`, and sets the conditions for retiring
the pin.
It also splits `ActivityBarItem.icon: string`, which conflated two different
primitives: a fixed symbol from a closed set, and an agent handle's initial.
They split at the item — `GlyphTabItem` vs `AvatarTabItem` — because a
field-level union preserves exactly the confusion that made the field hard to
read.
Three findings that reshaped the plan, each grounded in the code:
- The glyph lane repaints pixels inside at least 5 of the 11 committed
baselines, so it recaptures at T6; the pin removal then recaptures again.
An earlier draft scheduled all recapture in the pin PR, which would have
shipped a PR that fails the visual gate with no step to fix it.
- `.term-body` renders through `var(--cx-font-ui)` — there is no separate
terminal font stack — and `agent.png` captures the `stub-data.ts` fixture
glyphs, so the pin cannot retire until those two strings are ASCII.
- The union breaks two reads, not one: `{tab.icon}` and `tab.agentId`. T3 and
T4 therefore land as a single commit; split, the first is red at typecheck.
Ledger-impact: adds DL-366.
Co-authored-by: Matt Wilkinson <matt@rigel.build>
rigel-mintaka
force-pushed
the
compass-ux/3603-glyph-primitives-design
branch
from
September 12, 2026 20:52
122b0a5 to
4a2a557
Compare
mattwilkinsonn
approved these changes
Sep 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Compass UI chrome depends on 29 non-ASCII glyphs that neither brand face
covers, held up by a ~14 MB Unifont pin in the e2e toolchain. This record
adopts the dot-matrix
crispEdgesSVG technique DL-150/DL-199 already frozeand shipped in
StateDot/BadgeGlyph, and sets the conditions for retiringthe pin.
It also splits
ActivityBarItem.icon: string, which conflated two differentprimitives: a fixed symbol from a closed set, and an agent handle's initial.
They split at the item —
GlyphTabItemvsAvatarTabItem— because afield-level union preserves exactly the confusion that made the field hard to
read.
Three findings that reshaped the plan, each grounded in the code:
baselines, so it recaptures at T6; the pin removal then recaptures again.
An earlier draft scheduled all recapture in the pin PR, which would have
shipped a PR that fails the visual gate with no step to fix it.
.term-bodyrenders throughvar(--cx-font-ui)— there is no separateterminal font stack — and
agent.pngcaptures thestub-data.tsfixtureglyphs, so the pin cannot retire until those two strings are ASCII.
{tab.icon}andtab.agentId. T3 andT4 therefore land as a single commit; split, the first is red at typecheck.
Ledger-impact: adds DL-366.
Co-authored-by: Matt Wilkinson matt@rigel.build