test(compass-agent): widen the type-surface containment test budget to 130s (RIG-3784) - #1213
Merged
trunk-io[bot] merged 2 commits intoSep 13, 2026
Merged
Conversation
…o 130s (RIG-3784) `export-surface.test.ts` shells out to a cold `tsc --declaration` emit over the package, then walks a second TS program over the output. That is ~5s locally but 45-68s on a contended CI runner (~12-18x), and the 60s body budget left no headroom -- it timed out at 67.8s on an unrelated PR (#1190) and bounced other lanes. The emit is near its floor: scoping it to the index import-closure (5.47s) and in-process emit (8.52s) both measured slower than the current whole-package subprocess emit (3.2-4.2s). So the budget is the correct lever. Raise it to the house ceiling for slow bodies on this runner (cli.config-passthrough.test.ts), ~2x the worst observed run, with a why-comment distinguishing a body BUDGET from the RIG-3611 slow-cleanup DETECTOR.
|
😎 Merged successfully - details. |
… comment (RIG-3784) Review nit: the comment said ~12-18x but the quoted 5s local / 45-68s CI anchors give ~9-14x. Match the multiplier to the anchors; no behavior change.
|
Compass engineering docs preview: https://compass-agent-rig-3784-expor.compass-eng-docs.pages.dev Deployed from |
mattwilkinsonn
approved these changes
Sep 13, 2026
trunk-io
Bot
deleted the
compass-agent/rig-3784-export-surface-budget
branch
September 13, 2026 22:29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
export-surface.test.tsshells out to a coldtsc --declarationemit overthe package, then walks a second TS program over the output. That is ~5s
locally but 45-68s on a contended CI runner (~12-18x), and the 60s body
budget left no headroom -- it timed out at 67.8s on an unrelated PR (#1190)
and bounced other lanes.
The emit is near its floor: scoping it to the index import-closure (5.47s)
and in-process emit (8.52s) both measured slower than the current
whole-package subprocess emit (3.2-4.2s). So the budget is the correct
lever. Raise it to the house ceiling for slow bodies on this runner
(cli.config-passthrough.test.ts), ~2x the worst observed run, with a
why-comment distinguishing a body BUDGET from the RIG-3611 slow-cleanup
DETECTOR.