feat(server)!: delete the server-secret write path - #1220
Open
rigel-mintaka wants to merge 2 commits into
Open
Conversation
The server-secret VALUES are read at runtime through the provider, so rotation happens provider-side with the secretspec CLI and no RPC has to exist for it. The write RPCs bought nothing and kept a second, non-atomic write surface alive next to the DB-backed user path. Deletes SetServerSecret/DeleteServerSecret, their four messages, the `server-secret set` verb and the two admin-gate entries. ListServerSecrets and the value-free Statuses probe survive; the store-layer DeleteServerSecret query is declaration removal and is untouched. With the handlers gone the provider write half has no caller: shrinks secrets.Resolver to Resolve+Statuses and drops SpecResolver.Set/Delete, setArgs, WithCLI and defaultCLI. The secretspec CLI floor guard stays -- it now pins the operator's rotation path, keeping the CLI and the SDK read half on one release. Refs RIG-3655 Co-authored-by: Matt Wilkinson <matt@rigel.build>
This was referenced Sep 13, 2026
rigel-mintaka
added this pull request to stack #1188
September 13, 2026 22:11
|
Compass engineering docs preview: https://compass-server-rig-3655-t6-d.compass-eng-docs.pages.dev Deployed from |
Review found four comments still asserting the deleted Set/Delete seam exists, two of them telling a reader the write half survives. Also drops a phase reference from the seam assertion and narrows the name-cap rationale: server-secret names are server-declared at boot, not written at an RPC edge. Refs RIG-3655 Co-authored-by: Matt Wilkinson <matt@rigel.build>
mattwilkinsonn
approved these changes
Sep 14, 2026
|
Stacked PR 1223 failed testing in the merge queue. Please investigate the failure and re-submit the stack. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is part of a stack containing 4 PRs:
mainThe server-secret VALUES are read at runtime through the provider, so
rotation happens provider-side with the secretspec CLI and no RPC has to
exist for it. The write RPCs bought nothing and kept a second, non-atomic
write surface alive next to the DB-backed user path.
Deletes SetServerSecret/DeleteServerSecret, their four messages, the
server-secret setverb and the two admin-gate entries. ListServerSecretsand the value-free Statuses probe survive; the store-layer DeleteServerSecret
query is declaration removal and is untouched.
With the handlers gone the provider write half has no caller: shrinks
secrets.Resolver to Resolve+Statuses and drops SpecResolver.Set/Delete,
setArgs, WithCLI and defaultCLI. The secretspec CLI floor guard stays -- it
now pins the operator's rotation path, keeping the CLI and the SDK read half
on one release.
Refs RIG-3655
Co-authored-by: Matt Wilkinson matt@rigel.build