Feat/improved prompt handling - #55
Open
equist wants to merge 25 commits into
Open
Conversation
… test for max_age=0.
Added RemoveMaxAge to handle max_age the same way.
…eping the values otherwise so that the login page knows way login is shown.
…ocessed and should not re-trigger login so that it will also work with request objects.
JoStevensRSK
requested changes
Aug 4, 2026
Collaborator
There was a problem hiding this comment.
Changes to options classes require documentation updates. The UserInteraction options can be found under /reference/options
Explained the usage of the processed parameters.
Contributor
Author
|
I hope that I have fixed all your comments now. I'm sorry for missing unit tests and I'll do better next time :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Improvments of prompt and max_age parameter handling.
Type of change
[ ] Bug fix
[ x ] Feature
[ ] Refactoring
[ ] Documentation
[ ] Other
Implementation of feature #54.
Does this PR introduce a breaking change?
[ x ] Yes
[ ] No
The old code ignored unsupported prompt modes, but this implementation returns an error to the client.
Testing
I have fixed an error in an existing integration test.
There are several new integration tests.
LLM Usage
I have not used LLM, except for the extended auto-complete feature primarly used for XML comments.
I used co-pilot to set up some structure for the IdentityServerApplicationBuilderExtensionsTests class.
Other context
I believe this implementation is better aligned with current Duende IdentityServer implementation, but it is a breaking change compared to IdSrv 4 code base which ignored unsupported prompt values.