Skip to content

MNT: do not let one Python version cancel the other in the slow matrix #1100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Gui-FernandesBR merged 3 commits into from
Aug 8, 2026
Merged

MNT: do not let one Python version cancel the other in the slow matrix #1100

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
806a0d7
MNT: do not let one Python version cancel the other in the slow matrix
thc1006 Aug 8, 2026
67c002d
MNT: retry the VTK tests on SIGSEGV, not only on macOS SIGBUS
thc1006 Aug 8, 2026
acf350b
Merge branch 'develop' into mnt/pytest-matrix-fail-fast
Gui-FernandesBR Aug 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion .github/workflows/test-pytest-slow.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,9 @@ jobs:
pytest:
runs-on: ubuntu-latest
strategy:
# Same reason as the main matrix: 3.10 failing tells you nothing about
# 3.14, so cancelling it costs a result and saves nothing worth having.
fail-fast: false
matrix:
python-version: ["3.10", "3.14"]
env:
Expand Down Expand Up @@ -75,7 +78,10 @@ jobs:
else
status=$?
fi
if [[ "$status" != "138" || "$attempt" == "$attempts" ]]; then
# 138 is SIGBUS on macOS, 135 is SIGBUS on Linux, 139 is SIGSEGV on
# both. The measured split on this test was eight SIGSEGV to two
# SIGBUS, so keying on 138 alone let the common case through.
if [[ ! "$status" =~ ^(135|138|139)$ || "$attempt" == "$attempts" ]]; then
exit "$status"
fi
done
Expand Down
7 changes: 6 additions & 1 deletion .github/workflows/test_pytest.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,8 @@ jobs:
Pytest:
runs-on: ${{ matrix.os }}
strategy:
# One platform's result should not decide the other five. Added in #1084;
# kept explicit here so it does not get tidied away later.
fail-fast: false
matrix:
os: [ubuntu-latest, macos-latest, windows-latest]
Expand Down Expand Up @@ -85,7 +87,10 @@ jobs:
else
status=$?
fi
if [[ "$status" != "138" || "$attempt" == "$attempts" ]]; then
# 138 is SIGBUS on macOS, 135 is SIGBUS on Linux, 139 is SIGSEGV on
# both. The measured split on this test was eight SIGSEGV to two
# SIGBUS, so keying on 138 alone let the common case through.
if [[ ! "$status" =~ ^(135|138|139)$ || "$attempt" == "$attempts" ]]; then
exit "$status"
fi
done
Expand Down
Loading