BUG: seed parachute pressure noise with per-instance RNG (#1091) - #1134
Merged
Gui-FernandesBR merged 1 commit intoAug 14, 2026
Merged
Conversation
Gui-FernandesBR
force-pushed
the
bug/1091-parachute-noise-seed
branch
from
August 12, 2026 22:40
e43b8a8 to
36f9d6b
Compare
Gui-FernandesBR
approved these changes
Aug 12, 2026
Gui-FernandesBR
force-pushed
the
bug/1091-parachute-noise-seed
branch
from
August 14, 2026 00:11
36f9d6b to
469b750
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #1134 +/- ##
===========================================
+ Coverage 82.18% 83.29% +1.11%
===========================================
Files 122 130 +8
Lines 16355 17080 +725
===========================================
+ Hits 13441 14227 +786
+ Misses 2914 2853 -61 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
6 tasks
thc1006
added a commit
to thc1006/RocketPy
that referenced
this pull request
Aug 16, 2026
StochasticParachute.create_object derives the pressure noise seed after the draw, and RocketPy-Team#1134 relied on last_rnd_dict being the same dictionary to carry it into the record. Snapshotting the draw broke that link: the parachute is still built with the seed, but the record loses it, so the Monte Carlo inputs stop describing the parachute that flew. develop recorded 37773913418288439290323614982376424810 before recorded <absent> The source scan missed it because it only read dict_generator overrides. It reads create_object too now, and tracks the names a method binds from a draw rather than guessing at a variable name, so a local a method fills in for its own use is not mistaken for a record. Signed-off-by: thc1006 <84045975+thc1006@users.noreply.github.com>
thc1006
added a commit
to thc1006/RocketPy
that referenced
this pull request
Aug 25, 2026
StochasticParachute.create_object derives the pressure noise seed after the draw, and RocketPy-Team#1134 relied on last_rnd_dict being the same dictionary to carry it into the record. Snapshotting the draw broke that link: the parachute is still built with the seed, but the record loses it, so the Monte Carlo inputs stop describing the parachute that flew. develop recorded 37773913418288439290323614982376424810 before recorded <absent> The source scan missed it because it only read dict_generator overrides. It reads create_object too now, and tracks the names a method binds from a draw rather than guessing at a variable name, so a local a method fills in for its own use is not mistaken for a record. Signed-off-by: thc1006 <84045975+thc1006@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Parachutean optionalseedand a per-instancenumpy.random.Generatorso pressure noise no longer draws from the process-global RNG (Fixes #1091).StochasticParachuteinto created parachutes when Monte Carlo seeds the model.Test plan
PYTEST_DISABLE_PLUGIN_AUTOLOAD=1 PYTHONPATH=. pytest tests/unit/rocket/test_parachute_noise_seed.py tests/unit/rocket/test_parachute.py tests/unit/stochastic/test_stochastic_parachute.py