Skip to content

👷 Read Node.js version from mise.toml in action-docs - #222

Merged
Friedinger merged 1 commit into
mainfrom
ci/docs-node-version-file
Oct 18, 2026
Merged

Friedinger merged 1 commit into
mainfrom
ci/docs-node-version-file

Conversation

@Friedinger

Copy link
Copy Markdown
Member

The reusable docs workflow no longer hardcodes Node.js 24.21.0. It now reads the version from the calling repository via the new optional input node-version-file (default mise.toml).

Breaking: callers need a version file that defines Node.js, e.g. node in mise.toml. Intended to be released as a new major version.

Also adds a root mise.toml (Node.js 24.22.0) for this repository's own docs build, and documents the input in the CI/CD docs.

@github-actions github-actions Bot added the 👷 CI/CD Changes related to continuous integration/deployment label Oct 18, 2026
@coderabbitai

coderabbitai Bot commented Oct 18, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: e56ede9b-81a4-486b-974e-745f9408f991
📥 Commits

Reviewing files that changed from the base of the PR and between 71a3235 and 2dcb0c0.

📒 Files selected for processing: 3
  • .github/workflows/action-docs.yml
  • docs/src/development/ci-cd.md
  • mise.toml

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

Walkthrough

The documentation workflow now reads its Node.js version from a configurable file. The input defaults to mise.toml, which sets Node.js to 24.22.0. The CI/CD documentation describes the default and how to select another version file.

Changes

Documentation workflow Node.js version

Layer / File(s) Summary
Configure workflow Node.js version
.github/workflows/action-docs.yml, mise.toml, docs/src/development/ci-cd.md
The workflow accepts node-version-file, defaults to mise.toml, and passes the selected file to actions/setup-node. mise.toml sets Node.js to 24.22.0. The CI/CD docs describe the default and how to select another file.

Priority: ➖ Normal

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Feature

Merge Risk: ⚪ Minimal · up to 2dcb0

The docs workflow can use the calling repository’s configured Node.js version; its default mise.toml works, so no merge-blocking issue is established.

Pre-merge checks: Passed 5
Check name Status Explanation
Title check Passed The title clearly identifies the main change: reading the Node.js version from mise.toml in the reusable action-docs workflow. The emoji does not prevent understanding.
Description check Passed The description accurately explains the workflow change, breaking-change impact, new mise.toml file, and documentation update.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (3 skipped: 3 unsupported.)

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

A rabbit checks the version file,
Then hops along the workflow’s mile.
mise.toml says twenty-four,
Point to another file for more.
The docs now show the path to choose,
And bunny leaves with tidy shoes.

Comment @coderabbitai help to get the list of available commands.

@Friedinger
Friedinger requested a review from michisec October 18, 2026 09:05
@Friedinger
Friedinger merged commit 93c558c into main Oct 18, 2026
6 checks passed
@Friedinger
Friedinger deleted the ci/docs-node-version-file branch October 18, 2026 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

👷 CI/CD Changes related to continuous integration/deployment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants