Skip to content

👷 Use mise.toml as node-version-file for setup-node - #126

Merged
Friedinger merged 1 commit into
mainfrom
ci/setup-node-version-file
Oct 18, 2026
Merged

Friedinger merged 1 commit into
mainfrom
ci/setup-node-version-file

Conversation

@Friedinger

Copy link
Copy Markdown
Member

The Node.js version is now maintained only in mise.toml. actions/setup-node reads it via node-version-file, so the duplicate node-version entry in the workflows is gone.

@github-actions github-actions Bot added the 👷 CI/CD Changes related to continuous integration/deployment label Oct 18, 2026
@coderabbitai

coderabbitai Bot commented Oct 18, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 56 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 4996549b-7591-4cfb-a7fd-20c1601c800f
📥 Commits

Reviewing files that changed from the base of the PR and between 114d1b8 and 5fb8978.

📒 Files selected for processing: 1
  • .github/workflows/check-release.yml

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 7f695775-eac8-4a7c-bdd6-1991f0ae6353
📥 Commits

Reviewing files that changed from the base of the PR and between add20fd and 114d1b8.

📒 Files selected for processing: 1
  • .github/workflows/check-release.yml

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

Walkthrough

The Code Lint job in the release workflow now uses the Node.js version from mise.toml instead of a fixed version.

Changes

Release workflow

Layer / File(s) Summary
Node.js version setup
.github/workflows/check-release.yml
The Code Lint job now reads its Node.js version from mise.toml instead of using the fixed 24.21.0 version.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to 114d1

The release lint job will use Node.js 24.21.0 from mise.toml; no merge risk is indicated.

Pre-merge checks: Passed 5
Check name Status Explanation
Description check Passed The description accurately explains that workflows now read the Node.js version from mise.toml through actions/setup-node and remove duplicate version entries.
Title check Passed The title clearly identifies the main change: using mise.toml as the node-version-file for actions/setup-node.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

I’m a rabbit, quick to hop,
I saw a version pin drop.
Now mise.toml sets the pace,
Node.js finds its proper place.
I nibble greens and bound away!

Comment @coderabbitai help to get the list of available commands.

@Friedinger
Friedinger force-pushed the ci/setup-node-version-file branch from 114d1b8 to 5fb8978 Compare October 18, 2026 08:45
@Friedinger
Friedinger requested a review from michisec October 18, 2026 09:05
@Friedinger
Friedinger merged commit 8159a68 into main Oct 18, 2026
11 checks passed
@Friedinger
Friedinger deleted the ci/setup-node-version-file branch October 18, 2026 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

👷 CI/CD Changes related to continuous integration/deployment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants