feat: allow proxy bypassing with 'NONE' string#139
Conversation
Introduces the ability to bypass outbound proxies selectively in `booruQueriesDTO` proxy rotation settings. By explicitly supplying `"NONE"` as the `baseUrl` in the proxy policy, the system passes requests straight to the original origin without wrapping them in proxy URLs, enabling hybrid "some proxy, some direct" configurations (and thus naturally letting direct connections take their turn within the same round-robin schedule).
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (2)
📜 Recent review details🧰 Additional context used📓 Path-based instructions (3)src/**/*.ts📄 CodeRabbit inference engine (AGENTS.md)
Files:
**/*.spec.ts📄 CodeRabbit inference engine (AGENTS.md)
Files:
src/**/*.spec.ts📄 CodeRabbit inference engine (AGENTS.md)
Files:
🔇 Additional comments (2)
📝 WalkthroughWalkthroughOutbound proxy policies now accept ChangesOutbound Proxy Bypass
Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
✨ Simplify code
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
ESLint install timed out. The project may have too many dependencies for the sandbox. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
'NONE'as a valid magic string value forbaseUrlinBooruOutboundProxyPolicy.validateOutboundProxyPolicyto intercept'NONE'and avoid triggering normal URL validation checks.applyOutboundProxyto check forproxyPolicy.baseUrl === 'NONE'and return the upstream URL natively without wrapping it in a proxy.booru.service.spec.tsto assert that proxy generation handles both bypass and rotating states seamlessly.PR created automatically by Jules for task 15659793156989340818 started by @AlejandroAkbal
Summary by CodeRabbit