[reachrazamair]

Stacked on #1891 (and #1890 below it). Step 4 of the Group Chat composer parity plan (Plans/group-chat-composer-parity.md). No visual or behaviour change in AI chat.

What changed

• src/renderer/components/ChatComposer/capabilities.ts holds ComposerCapabilities: imageAttach, upload, voice, saveToHistory, permission, thinking, modelEffort.
  • deriveAiComposerCapabilities() builds the AI's flags. Terminal mode offers nothing, permission comes from supportsReadOnlyMode, and thinking from the existing supportsThinking.
  • aiCanAttachImages() is the old attach rule moved into one function; InputArea uses it for its other attach checks too.
  • GROUP_CHAT_COMPOSER_CAPABILITIES is a frozen constant (attach, upload and voice on, the four per-tab agent settings off). Nothing renders it yet; the next step does.
• ToolbarControls no longer takes a Session. It takes permissionMode, terminalCwd and agentId as values. Tab changes go out through onPermissionModeChange / onThinkingModeChange, which the new useAiTabToolbarBinding supplies for AI, with callbacks that depend only on the agent and tab ids. InputArea memoizes the capabilities object, so typing does not hand the toolbar new props.
• toolbarExtras is a slot in the toggle group, ready for the room's Read-Only toggle.
• The Prompt Composer button shows when its callback is passed, and the phone sheet mounts when one of its section flags is on, so neither needed a new flag.

Deviation from the plan's flag list

The plan lists 13 flags. Only the seven above have a reader today, so the other six are deferred to the step that first reads each: commandMode, slashCommands and shellTabCompletion (step 8), fileMentions (step 6 or 8), mentionRouting (step 8), and sendMenu (step 8 at the earliest, and possibly never, since the send column already takes its menu as a prop). The plan document records this.

Tests

ToolbarControls.test.tsx is the only existing test changed: it built session props and checked tab writes through a mocked updateSessionWith, and now passes capabilities and values and checks the callbacks. The tab-write checks moved to useAiTabToolbarBinding.test.ts. ComposerOptionsSheet and the InputArea tests pass unchanged. New tests cover each AI flag from its source, the room constant, controls hidden by their flag, and the toolbarExtras placement.

Found, not fixed here

On a phone, AI terminal mode draws a "..." with no sheet behind it. That predates this change; a test now pins the current behaviour.

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

🗂️ Base branches to auto review: 2

• main
• rc

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

• Source mode: Auto
• Repository: RunMaestro/Maestro
• Branch: refactor/composer-capabilities
• File: .coderabbit.yaml
• Commit: 7a06492
• Layers: Repository YAML
• Review profile: CHILL
• Plan: Advanced
• Run ID: 0452b72d-3fe1-4365-94eb-0e1ff1ea4c75

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[greptile-apps]

Confidence Score: 5/5

[Medium impact] The PR appears safe to merge; no actionable regression was found.

Summary

Moves optional toolbar controls behind ComposerCapabilities and moves AI tab writes into useAiTabToolbarBinding.

• The AI toolbar gets its controls and tab settings through a shared contract.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart LR
  A[InputArea] --> B[deriveAiComposerCapabilities]
  A --> C[useAiTabToolbarBinding]
  B --> D[ToolbarControls]
  C --> D
  D --> E[Desktop controls]
  D --> F[ComposerOptionsSheet]
  E --> C
  F --> C
  C --> G[updateSessionWith]

Loading

_{Reviews (1) · Last reviewed commit: "refactor(composer): toolbar reads Compos..." · Reviewed by Greptile}