Conversation
P-E-P
force-pushed
the
extern_prelude_2
branch
3 times, most recently
from
August 24, 2026 00:31
b8dd134 to
64c7d0b
Compare
P-E-P
force-pushed
the
extern_prelude_2
branch
2 times, most recently
from
September 28, 2026 17:59
4a55587 to
5fe50cf
Compare
We usually test components independently, this means we did not test for lang item declaration within external crate. This commit introduces a new test directory to test external crate boundary. gcc/testsuite/ChangeLog: * rust/minicore/extern_lang_items.rs: New test. * rust/minicore/extern_lang_items_core/lib.rs: New test. * rust/minicore/minicore.exp: New test. Signed-off-by: Pierre-Emmanuel Patry <pierre-emmanuel.patry@embecosm.com>
Macros are already emitted by the AST dump within metadata files, we no longer require a separate export pass from within the metadata exporter. gcc/rust/ChangeLog: * metadata/rust-export-metadata.cc (PublicInterface::gather_export_data): Do not emit macros separately anymore. Signed-off-by: Pierre-Emmanuel Patry <pierre-emmanuel.patry@embecosm.com>
Return the injected crate's node id. gcc/rust/ChangeLog: * ast/rust-ast.cc (Crate::inject_extern_crate): Return the injected crate's node id. * ast/rust-ast.h: Update the function's prototype. Signed-off-by: Pierre-Emmanuel Patry <pierre-emmanuel.patry@embecosm.com>
Kernel and core related tests as well as their core crate needs to be compiled with a matching rust edition. In order to enforce that we control the edition from the testsuite instead of relying on a per crate edition change. Moreover, the kernel and core 1.49 is meant to be compiled with rust edition 2018, using this edition will make things easier for us. gcc/testsuite/ChangeLog: * rust/minicore/minicore.exp: Enforce crate edition at test top level. Signed-off-by: Pierre-Emmanuel Patry <pierre-emmanuel.patry@embecosm.com>
Node streaming started from the root and did not walk through the different preludes within the forever stack. This enables a more complete representation of the forever stack. gcc/rust/ChangeLog: * resolve/rust-forever-stack.hxx: Stream extern and lang prelude nodes. Signed-off-by: Pierre-Emmanuel Patry <pierre-emmanuel.patry@embecosm.com>
This data structure is complex, when using the debug dump within a debugger we often need to know what is the current state and where new nodes will be pushed within the forever stack. gcc/rust/ChangeLog: * resolve/rust-forever-stack.hxx: Debug the forever stack cursor position. Signed-off-by: Pierre-Emmanuel Patry <pierre-emmanuel.patry@embecosm.com>
We did not assign any node id to neither extern and lang prelude nodes and this was confusing and could lead to unexpected behaviors (duplicate ids). gcc/rust/ChangeLog: * resolve/rust-forever-stack.h: Assign a node id to extern and lang nodes. Signed-off-by: Pierre-Emmanuel Patry <pierre-emmanuel.patry@embecosm.com>
Extern crates were not inserted within the extern prelude. gcc/rust/ChangeLog: * ast/rust-ast.cc (Crate::inject_extern_crate): Inject extern crates at the beginning of the crate instead of the end. * resolve/rust-forever-stack.h: Add function prototype to insert a crate within the extern prelude. * resolve/rust-forever-stack.hxx: Add function to insert extern crate within extern prelude. * resolve/rust-name-resolution-context.cc (NameResolutionContext::insert_crate_in_prelude): Insert extern crate within all extern prelude namespaces. * resolve/rust-name-resolution-context.h: Add function prototype. * resolve/rust-toplevel-name-resolver-2.0.cc (TopLevel::visit): Inject extern crate within extern prelude during top level nr. Signed-off-by: Pierre-Emmanuel Patry <pierre.emmanuel.patry@opensrcsec.com>
Top level module should collide with extern crate names and the error should be reported on the module, not the extern crate because the latter may not have a source location given it may have been injected. gcc/testsuite/ChangeLog: * rust/minicore/top_core_modules.rs: New test. * rust/minicore/top_core_modules_core/lib.rs: New test. Signed-off-by: Pierre-Emmanuel Patry <pierre.emmanuel.patry@opensrcsec.com>
P-E-P
force-pushed
the
extern_prelude_2
branch
from
September 29, 2026 12:05
1d28c39 to
86dfa55
Compare
P-E-P
marked this pull request as ready for review
September 29, 2026 12:05
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.