gccrs: fix bad projection normalize - #4810
Merged
Merged
Conversation
What can happen depending on order of operation is that the non trait position projections can resolve to generics where we can attempt to get the underlying type and base the projection on that. Fixes #4804 gcc/rust/ChangeLog: * typecheck/rust-type-util.cc (normalize_projection): add check gcc/testsuite/ChangeLog: * rust/execute/torture/issue-4804.rs: New test. Signed-off-by: Philip Herron <herron.philip@googlemail.com>
powerboat9
enabled auto-merge
August 23, 2026 13:27
powerboat9
disabled auto-merge
August 23, 2026 14:01
Collaborator
|
@philberty is that issue reference in the commit body right? I don't know if the github ui is screwing with me or not. |
Collaborator
Thank you github ui. |
Member
Author
|
yeah it was to fix this #4804 where you fixed the lang item lookups |
Collaborator
|
The github ui likes to visually replace |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What can happen depending on order of operation is that the non trait position projections can resolve to generics where we can attempt to get the underlying type and base the projection on that.
Fixes #4804
gcc/rust/ChangeLog:
gcc/testsuite/ChangeLog: