Conversation
u7k4rs6
force-pushed
the
fix-4739-enum-struct-variant-refutable
branch
from
September 17, 2026 13:35
400c253 to
987539a
Compare
CohenArthur
approved these changes
Sep 17, 2026
CohenArthur
left a comment
CohenArthur
left a comment
Member
There was a problem hiding this comment.
LGTM, thanks! nit but if you want in your changelog you can move the (StructPattern::is_refutable): Handle enum patterns with multiple variants. line above so it fills out more of the previous line
u7k4rs6
force-pushed
the
fix-4739-enum-struct-variant-refutable
branch
from
September 19, 2026 18:34
987539a to
7d57d75
Compare
StructPattern::is_refutable asserted that the ADT was not an enum, so struct patterns naming enum variants hit the assert. Return true for multi-variant enums and continue with the existing field checks for single-variant enums. Fixes Rust-GCC#4739 gcc/rust/ChangeLog: * hir/tree/rust-hir-pattern-abstract.cc (StructPattern::is_refutable): Handle enum patterns with multiple variants. gcc/testsuite/ChangeLog: * rust/compile/irrefutable-struct-variant.rs: New test. * rust/compile/refutable-struct.rs: Add regression tests for enum variant patterns in function parameters and let bindings. Signed-off-by: Utkarsh Bahuguna <utkarshbahuguna10@gmail.com>
u7k4rs6
force-pushed
the
fix-4739-enum-struct-variant-refutable
branch
from
September 19, 2026 18:35
7d57d75 to
e4e901a
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4739
StructPattern::is_refutable asserted that the ADT was not an enum, so struct patterns naming enum variants hit the assert. Return true for multi-variant enums and continue with the existing field checks for single-variant enums.
make check-rust passes cleanly with no unexpected failures.
This is independent of #4808. It changes a different function in the same file and the two changes do not overlap.