Add base feature gating for derive(CoercePointee) - #4841
Merged
Merged
Conversation
CohenArthur
added
the
rust-for-linux
CohenArthur
force-pushed
the
derive-coerce-pointee-base-impl
branch
from
September 18, 2026 16:36
159f32a to
696df5c
Compare
P-E-P
self-requested a review
September 28, 2026 08:23
P-E-P
approved these changes
Sep 28, 2026
| {"Ord", BuiltinMacro::Ord}, | ||
| {"PartialOrd", BuiltinMacro::PartialOrd}, | ||
| {"Hash", BuiltinMacro::Hash}, | ||
| // FIXME: Only in compatibility mode >= 1.84 |
Member
There was a problem hiding this comment.
This comment confuses me. Should we forbid this builtin macro outside of the feature gating mechanisms ? If so we should probably implement a filtering function and restrict their access completely.
Member
Author
There was a problem hiding this comment.
I think we can probably remove the comment tbh. At this point the check will happen anyways and the macro won't resolve if we're not in compatibility mode.
gcc/rust/ChangeLog: * checks/errors/feature/rust-feature-gate.cc (FeatureGate::visit): Add missing call to default visitor for ExternType items.
Gate derive(CoercePointee) behind `#
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds more functionality to the BuiltinAttributeChecker class and allows it to
store the list of parsed crate features. The class will then keep an instance of FeatureGate,
and will be able to gate nightly attributes should it need to. This is particularly useful for
checking unstable built-in derives before they get desugared and removed by macro expansion.
We then gate derive(CoercePointee) behind
#![feature(derive_coerce_pointee)and start adding theinfrastructure required to support the derive.