backend: Properly implement remainder operation for f32 and f64 - #4943
Open
CohenArthur wants to merge 1 commit into
Open
CohenArthur wants to merge 1 commit into
CohenArthur wants to merge 1 commit into
Conversation
Member
Author
|
This is required to properly implement the |
CohenArthur
commented
Sep 29, 2026
CohenArthur
force-pushed
the
fix-float-remainder
branch
3 times, most recently
from
October 2, 2026 12:46
2f69b6e to
4cbbbb1
Compare
When performing the mod/remainder operation on floating point values, we cannot simply make a
fold_build2 binary op as this operation is not defined in later passes of GCC for f32 and f64.
We have to call the remainder{,f,l} builtins and store the result instead.
This was previously uncaught in our testsuite, and the associated testcase would simply ICE.
gcc/rust/ChangeLog:
* rust-gcc.cc (builtin_remainder_float_call): New function.
(maybe_extend_precision): Likewise.
(arithmetic_or_logical_expression): Call them and adapt logic.
gcc/testsuite/ChangeLog:
* rust/compile/float-rem.rs: New test.
Collaborator
|
LGTM besides the merge conflicts |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When performing the mod/remainder operation on floating point values, we cannot simply make a fold_build2 binary op as this operation is not defined in later passes of GCC for f32 and f64. We have to call the remainder{,f,l} builtins and store the result instead.
This was previously uncaught in our testsuite, and the associated testcase would simply ICE.
gcc/rust/ChangeLog:
gcc/testsuite/ChangeLog: