-
Notifications
You must be signed in to change notification settings - Fork 39
WireMod Closure Update for sbncode develop #663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
gputnam
wants to merge
21
commits into
develop
Choose a base branch
from
feature/fpoppi_wiremod_diagnostic_gputnam_dev
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
41e4fa4
add wiremod to sbncode
hausnerh f25dccc
update for v10
tbwester 52892eb
WireMod for sbnd production branch
tbwester cb5d01b
fix build
tbwester f8a9ea7
add WireMod in X vs theta_XW
hausnerh eda8542
I believe this is the correct ThXW calculation...
hausnerh 60d87e6
Slight tweak to ThXW so it's calc'd once
hausnerh 2060d5d
bug fixes to the WM util + slightly smarting handling to the EDep pro…
hausnerh ed07bb3
fix a few spaces & typos
hausnerh d9be306
Catch and ignore non-active energy depositions.
gputnam 825d480
Fix ThetaZ/angletovert discrepency in calculating the pitch
hausnerh 3e691fb
add pathological check on small q_orig scaling
hausnerh 26b359b
Hide q_orig warning under verbose. Add in sigma_distance check.
gputnam 9118f6f
Fix sq code.
gputnam 206a9d0
Fix WM sigma cut to 3^2=9.
gputnam 63b9e1c
Fix operator precedence bug.
gputnam 8d37cd1
Addition of some WireMod diagnostic tools, addition of some flags (us…
francescopoppi 645ea90
Build fixes.
gputnam bb09f01
Add in utilities to lookup truth information from SimChannel's
gputnam 8c006e8
Fix thXW calculation.
gputnam 78c362b
Some fixes to wiremod utility. First we removed the modification cuto…
francescopoppi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| add_subdirectory(Utility) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,49 @@ | ||
| cet_make_library( | ||
| LIBRARY_NAME | ||
| sbncode_WireMod_Utility | ||
|
|
||
| SOURCE | ||
| WireModUtility.cc | ||
|
|
||
| LIBRARIES | ||
| ${ART_FRAMEWORK_CORE} | ||
| ${MF_MESSAGELOGGER} | ||
| ${Boost_SYSTEM_LIBRARY} | ||
| ${ROOT_BASIC_LIB_LIST} | ||
| ${ROOT_HIST} | ||
| art_root_io::TFileService_service | ||
| larcorealg::Geometry | ||
| larcore::Geometry_Geometry_service | ||
| lardataobj::AnalysisBase | ||
| lardataobj::RawData | ||
| lardataobj::RecoBase | ||
| lardataobj::Simulation | ||
| nusimdata::SimulationBase | ||
| larevt::SpaceCharge | ||
| sbnobj::ICARUS_TPC | ||
| lardataalg::DetectorInfo | ||
| lardata::RecoObjects | ||
| lardata::Utilities | ||
| larreco::RecoAlg | ||
| ${LARRECO_LIB} | ||
| ${LARDATA_LIB} | ||
| ${ART_FRAMEWORK_CORE} | ||
| ${ART_FRAMEWORK_PRINCIPAL} | ||
| ${ART_FRAMEWORK_SERVICES_REGISTRY} | ||
| ${ART_FRAMEWORK_SERVICES_OPTIONAL} | ||
| ${ART_FRAMEWORK_SERVICES_OPTIONAL_RANDOMNUMBERGENERATOR_SERVICE} | ||
| ${ART_FRAMEWORK_SERVICES_OPTIONAL_TFILESERVICE_SERVICE} | ||
| ${MF_MESSAGELOGGER} | ||
| ${FHICLCPP} | ||
| ${CLHEP} | ||
| ${ROOT_GEOM} | ||
| ${ROOT_XMLIO} | ||
| ${ROOT_GDML} | ||
| ${ROOT_BASIC_LIB_LIST} | ||
| ${ROOT_HIST} | ||
| BASENAME_ONLY | ||
| ) | ||
|
|
||
| install_headers() | ||
| install_source() | ||
|
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a stopping comment, but do we want the float precision to default to
false? I like having it as a fhicl parameter, but we should make sure that the defaults match the most common use-case