Repository navigation
6.8.0-rc3 fixes from RC2 testing - #2682
Merged
Merged
Conversation
pip unpacks the whole install (~7 GB with CUDA) into TMPDIR before moving it into --target, so the on-demand install failed with "No space left on device" on systems with a small /tmp. light-the-torch also exited 0 after pip failed, which produced a misleading "install completed but cannot be imported" error. Point TMPDIR at a temp dir next to the per-user site-packages, and verify that torch imports before reporting success, in both Studio/CLI and Python.
The uninstaller unregistered ".swprojc" instead of ".swproj", and without SetRegView 64 it deleted its registry keys from the 32-bit view while the installer wrote them to the 64-bit view.
initialize_path_handling() imbued a UTF-8 codecvt into boost::filesystem on every platform. On POSIX, imbue() first builds boost's default locale from the environment, which throws when LANG names a locale that isn't installed (e.g. LANG=en_US), aborting shapeworks, Studio and the Python module. The conversion only matters on Windows, so only do it there.
The message still told users to run install_shapeworks.sh and activate a conda env, which no longer applies with bundled Python.
6.8 builds target macOS 14, but nothing stopped installing or running on older versions, where it failed with cryptic errors (e.g. numpy's Accelerate build missing symbols on macOS 12). The .pkg is now wrapped in a distribution package whose installation check refuses older macOS, Studio sets LSMinimumSystemVersion, and Studio, the shapeworks CLI and swpython check the OS version at startup. Document the requirement in the install docs and release notes.
The last PyTorch with Intel macOS builds (2.2) was built against numpy 1.x and can't exchange arrays with the bundled numpy 2.x, so DeepSSM would install torch and then fail partway through. Studio, the deepssm CLI command and ensure_torch() now stop with a clear message on Intel Macs before downloading anything. Document the limitation.
DeepSSM is unsupported there, so the tests now skip instead of failing. They passed in CI only because the conda test env installs numpy<2 on Intel Macs, unlike the shipped bundle.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes found while testing 6.8.0-rc2 installs on Linux, macOS and Windows.
/tmpno longer fails it, and a failed pip install is reported as such.LANGnames a locale that isn't installed (e.g.LANG=en_US).swpython) and documented, instead of failing with cryptic errors on older macOS..swprojassociation and its registry keys.RunUseCase.pyimport errors point atswpythoninstead of conda.