Repository navigation
gp: fix off-diagonal kernel metric bug - #131
Merged
Merged
Conversation
* add test for regression
Collaborator
Author
|
Once again we're running into failing linting. @akilnarayan, this should still be good to go if it looks alright to you. |
akilnarayan
approved these changes
Oct 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix bug in einsum indexing that caused off-diagonal metric terms to be ignored, and added test for regression (cuz why not?).
@akilnarayan, this is the bug I mentioned to Karli and Eli in our meeting.