Repository navigation
[autobackport: sssd-2-9] tests: Add tests for AD Forest multidomain and gpo tests - #9394
Merged
jakub-vavra-cz merged 2 commits intoOct 7, 2026
Conversation
jakub-vavra-cz
requested review from
jakub-vavra-cz
and removed request for
danlavu and
thalman
October 7, 2026 11:49
jakub-vavra-cz
approved these changes
Oct 7, 2026
jakub-vavra-cz
left a comment
jakub-vavra-cz
left a comment
Contributor
There was a problem hiding this comment.
Clean cherry-pick.
Re-design and rewrite of legacy sssd-qe ad_forest and admultidomain suites into test_adforest.py and test_adforest_gpo.py. These suites are downstream (idmci) only. Deprecates: sssd-qe/client/ad_provider/ad_forest sssd-qe/client/ad_provider/ad_gpo_hbac_multidomain sssd/src/tests/multihost/admultidomain/test_multidomain.py Not covered (different topology): sssd/src/tests/multihost/admultidomain/test_multiforest.py Assisted-by: Cursor Reviewed-by: Dan Lavu <dlavu@redhat.com> Reviewed-by: Tomáš Halman <thalman@redhat.com> (cherry picked from commit be221ad) Reviewed-by: Jakub Vávra <jvavra@redhat.com>
Match remaining test names to generic suites, group cases by feature, and break up the initgroups helper for readability. Move fixtures so passkey tests are not broken. Assisted-by: Cursor Reviewed-by: Dan Lavu <dlavu@redhat.com> Reviewed-by: Tomáš Halman <thalman@redhat.com> (cherry picked from commit c611c78) Reviewed-by: Jakub Vávra <jvavra@redhat.com>
Contributor
Author
|
The pull request was accepted by @jakub-vavra-cz with the following PR CI status: 🟢 CodeQL (success) There are unsuccessful or unfinished checks. Make sure that the failures are not related to this pull request before merging. |
sssd-bot
force-pushed
the
SSSD-sssd-backport-pr9045-to-sssd-2-9
branch
from
October 7, 2026 13:19
0f0cb17 to
4c508c1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of PR#9045 tests: Add tests for AD Forest multidomain and gpo tests to branch sssd-2-9, created by @jakub-vavra-cz.
Please make sure this backport is correct.
Note
The commits were cherry-picked without conflicts.
You can push changes to this pull request
Original commits
be221ad - tests: add AD forest multidomain system tests
c611c78 - tests: Align AD forest test names and grouping
Backported commits
Original Pull Request Body
Re-design and rewrite of legacy sssd-qe ad_forest and admultidomain suites into test_adforest.py and test_adforest_gpo.py. Covers lookup, auth, simple access, ad_access_filter, join other DC scenarios.
These suites are downstream (idmci) only.
Deprecates:
sssd-qe/client/ad_provider/ad_forest
sssd-qe/client/ad_provider/ad_gpo_hbac_multidomain
sssd/src/tests/multihost/admultidomain/test_multidomain.py
Not covered (different topology):
sssd/src/tests/multihost/admultidomain/test_multiforest.py
Depends on SSSD/sssd-test-framework#263