Skip to content

[autobackport: sssd-2-9-4] tests: Add tests for AD Forest multidomain and gpo tests - #9396

Merged
jakub-vavra-cz merged 2 commits into
SSSD:sssd-2-9-4from
sssd-bot:SSSD-sssd-backport-pr9045-to-sssd-2-9-4
Oct 8, 2026
Merged

jakub-vavra-cz merged 2 commits into
SSSD:sssd-2-9-4from
sssd-bot:SSSD-sssd-backport-pr9045-to-sssd-2-9-4

Conversation

@sssd-bot

@sssd-bot sssd-bot commented Oct 7, 2026

Copy link
Copy Markdown
Contributor

This is an automatic backport of PR#9045 tests: Add tests for AD Forest multidomain and gpo tests to branch sssd-2-9-4, created by @jakub-vavra-cz.

Caution

@jakub-vavra-cz The patches did not apply cleanly. It is necessary to resolve conflicts before merging this pull request. Commits that introduced conflict are marked with CONFLICT!.

You can push changes to this pull request

git remote add sssd-bot git@github.com:sssd-bot/sssd.git
git fetch sssd-bot refs/heads/SSSD-sssd-backport-pr9045-to-sssd-2-9-4
git checkout SSSD-sssd-backport-pr9045-to-sssd-2-9-4
git push sssd-bot SSSD-sssd-backport-pr9045-to-sssd-2-9-4 --force

Original commits
be221ad - tests: add AD forest multidomain system tests
c611c78 - tests: Align AD forest test names and grouping

Backported commits

  • fcf5161 - CONFLICT! tests: add AD forest multidomain system tests
  • fab3747 - tests: Align AD forest test names and grouping

Conflicting Files Information (check for deleted and re-added files)

  • CONFLICT! tests: add AD forest multidomain system tests
On branch SSSD-sssd-backport-pr9045-to-sssd-2-9-4
You are currently cherry-picking commit be221ad82.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   src/tests/system/conftest.py
	new file:   src/tests/system/tests/__init__.py
	new file:   src/tests/system/tests/adforest_fixtures.py
	new file:   src/tests/system/tests/test_adforest.py
	new file:   src/tests/system/tests/test_adforest_gpo.py

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)
	deleted by us:   src/tests/system/tests/readme.rst

Original Pull Request Body

Re-design and rewrite of legacy sssd-qe ad_forest and admultidomain suites into test_adforest.py and test_adforest_gpo.py. Covers lookup, auth, simple access, ad_access_filter, join other DC scenarios.

These suites are downstream (idmci) only.

Deprecates:
sssd-qe/client/ad_provider/ad_forest
sssd-qe/client/ad_provider/ad_gpo_hbac_multidomain
sssd/src/tests/multihost/admultidomain/test_multidomain.py

Not covered (different topology):
sssd/src/tests/multihost/admultidomain/test_multiforest.py

Depends on SSSD/sssd-test-framework#263

Re-design and rewrite of legacy sssd-qe ad_forest
and admultidomain suites into test_adforest.py
and test_adforest_gpo.py.

These suites are downstream (idmci) only.

Deprecates:
sssd-qe/client/ad_provider/ad_forest
sssd-qe/client/ad_provider/ad_gpo_hbac_multidomain
sssd/src/tests/multihost/admultidomain/test_multidomain.py

Not covered (different topology):
sssd/src/tests/multihost/admultidomain/test_multiforest.py

Assisted-by: Cursor
Reviewed-by: Dan Lavu <dlavu@redhat.com>
Reviewed-by: Tomáš Halman <thalman@redhat.com>
Match remaining test names to generic suites, group cases by feature, and
break up the initgroups helper for readability.
Move fixtures so passkey tests are not broken.

Assisted-by: Cursor
Reviewed-by: Dan Lavu <dlavu@redhat.com>
Reviewed-by: Tomáš Halman <thalman@redhat.com>
@jakub-vavra-cz
jakub-vavra-cz force-pushed the SSSD-sssd-backport-pr9045-to-sssd-2-9-4 branch from fab3747 to e4b7721 Compare October 7, 2026 11:59
@jakub-vavra-cz
jakub-vavra-cz marked this pull request as ready for review October 7, 2026 12:00
@jakub-vavra-cz
jakub-vavra-cz removed the request for review from danlavu October 7, 2026 12:00
@jakub-vavra-cz

Copy link
Copy Markdown
Contributor

Dropped the conflicting src/tests/system/tests/readme.rst from the PR.

@jakub-vavra-cz
jakub-vavra-cz requested review from jakub-vavra-cz and removed request for thalman October 7, 2026 17:59
@sssd-bot

sssd-bot commented Oct 7, 2026

Copy link
Copy Markdown
Contributor Author

The pull request was accepted by @jakub-vavra-cz with the following PR CI status:


🟢 CodeQL (success)
🟢 ci / prepare (success)
⚪ ci / system (centos-8) (cancelled)
🟢 Static code analysis / codeql (success)
🟢 Static code analysis / files-changed (success)
🟢 Static code analysis / pre-commit (success)
🟢 Static code analysis / python-system-tests (success)


There are unsuccessful or unfinished checks. Make sure that the failures are not related to this pull request before merging.

@jakub-vavra-cz
jakub-vavra-cz merged commit 648095b into SSSD:sssd-2-9-4 Oct 8, 2026
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants