Repository navigation
[autobackport: sssd-2-9] tests: remove legacy intg test suite - #9426
Merged
alexey-tikhonov merged 4 commits intoOct 12, 2026
Merged
alexey-tikhonov merged 4 commits into
alexey-tikhonov merged 4 commits into
Conversation
danlavu
force-pushed
the
SSSD-sssd-backport-pr9078-to-sssd-2-9
branch
from
October 11, 2026 01:02
902e8fe to
933fb9a
Compare
danlavu
force-pushed
the
SSSD-sssd-backport-pr9078-to-sssd-2-9
branch
3 times, most recently
from
October 11, 2026 02:52
87433c1 to
ac28268
Compare
danlavu
marked this pull request as ready for review
October 11, 2026 04:53
danlavu
marked this pull request as draft
October 12, 2026 13:09
danlavu
marked this pull request as ready for review
October 12, 2026 13:41
alexey-tikhonov
approved these changes
Oct 12, 2026
alexey-tikhonov
approved these changes
Oct 12, 2026
pbrezina
approved these changes
Oct 12, 2026
Remove the legacy Python/pytest-based intg test suite (src/tests/intg) and its build glue (intgcheck.m4, contrib/ci --moderate scope, screenrc/cwrap config). Coverage has moved to the system test suite (src/tests/system) and to make check under Valgrind in GitHub Actions. - Extract the Valgrind check into its own script, contrib/ci/check-valgrind. - Fix check-valgrind's log glob to recurse into SUBDIRS test directories. - Remove the now-dead INTGCHECK_BUILD guard in src/responder/pam/pamsrv.c. - Remove the AM_CHECK_PAM_WRAPPER/HAVE_SLAPD configure checks it needed. - Drop the unused --essential/--moderate run option. - Remove the obsolete run-multihost and clean scripts. - Update contrib/ci/README.md to match. - Remove the 'intgcheck' CI matrix entry and its GitHub Actions job. - Build make/make check/distcheck with -g3 for better Valgrind backtraces. AI: Claude Sonnet 5 Co-authored-by: Cursor <cursoragent@cursor.com> Reviewed-by: Alexey Tikhonov <atikhono@redhat.com> Reviewed-by: Pavel Březina <pbrezina@redhat.com>
…tab leak - Replace the two remaining "contrib/ci/run --deps-only" invocations with a direct call to deps_install(). - Remove contrib/ci/run and misc.sh, now without any callers. - Remove contrib/ci/README.md, which only documented the removed run entry point. - Trim deps.sh's DEPS_LIST of packages only needed by the legacy intg suite. - Remove the now-unused deps_remove()/distro_pkg_remove() helpers. - Remove the now-unreachable contrib/ci/sssd.debian.supp. - Reword the -g3 comment in build.yml's make step to explain it's for Valgrind. - Rename the 'multihost' CI matrix key to 'system'. - Clean up the two-way IPA subdomain trust test's keytab right after that test, fixing a `make distcheck` distcleancheck failure. - Add the missing sssd-leak-netlink suppression to sssd.supp, needed because this branch's test_ipa_subdomains_server.c forks real child processes under the newly added check-valgrind step. - Remove the unused .github/actions/build-sssd-srpm composite action. AI: Claude Sonnet 5 Co-authored-by: Cursor <cursoragent@cursor.com> Reviewed-by: Alexey Tikhonov <atikhono@redhat.com> Reviewed-by: Pavel Březina <pbrezina@redhat.com> Co-authored-by: Cursor <cursoragent@cursor.com>
- Move coverity.yml and the codeql job onto the Fedora container make-distcheck already builds in. - Drop the now-dead Debian package list and configure quirk from deps.sh/configure.sh. - Drop Debian distro detection and apt-get install logic from distro.sh. AI: Claude Sonnet 5 Co-authored-by: Cursor <cursoragent@cursor.com> Reviewed-by: Alexey Tikhonov <atikhono@redhat.com> Reviewed-by: Pavel Březina <pbrezina@redhat.com>
The "CI: drop Debian as a build target" commit moves the codeql job onto the ci-client-devel container make-distcheck already builds in, which has a newer OpenSSL where ASN1_STRING is opaque. This branch's src/lib/certmap/sss_cert_content_crypto.c predates master's "Drop support of OpenSSL < 3.0.8" effort (PR SSSD#8761) and no longer compiles under that OpenSSL, so codeql cannot pass here without also backporting that much larger, unrelated effort. Drop the codeql job on this branch rather than carry a permanently failing required check; it can be restored once this branch picks up OpenSSL < 3.0.8 removal to match master. AI: Claude Sonnet 5 Co-authored-by: Cursor <cursoragent@cursor.com> Reviewed-by: Alexey Tikhonov <atikhono@redhat.com> Reviewed-by: Pavel Březina <pbrezina@redhat.com>
Contributor
Author
|
The pull request was accepted by @danlavu with the following PR CI status: 🟢 rpm-build:centos-stream-9-x86_64:upstream (success) There are unsuccessful or unfinished checks. Make sure that the failures are not related to this pull request before merging. |
sssd-bot
force-pushed
the
SSSD-sssd-backport-pr9078-to-sssd-2-9
branch
from
October 12, 2026 17:26
5dd3bfe to
70e908b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of PR#9078 tests: remove legacy intg test suite to branch sssd-2-9, created by @danlavu.
Original commits
cbdb054 - tests: remove legacy intg test suite
5ce9d9e - CI: trim unused deps.sh/distro.sh helpers, rename matrix key, fix keytab leak
056c2e7 - CI: drop Debian as a build target
Backported commits
Additional commit (not part of upstream PR#9078)
re-points the
codeqljob at theci-client-develcontainermake-distcheckalready builds in, which has a newer OpenSSL whereASN1_STRINGis opaque andi2d_ASN1_TYPEis no longer usable theway this branch's
src/lib/certmap/sss_cert_content_crypto.cexpects. A full fix requires a much larger, deliberate "Drop support
of OpenSSL < 3.0.8" effort (master PR Drop support of OpenSSL < 3.0.8 #8761) not yet applied here,
so rather than carry a permanently-red required check, this commit
drops the
codeqljob on this branch. It can be restored once thisbranch picks up OpenSSL < 3.0.8 removal to match master.
Conflict resolution notes
All 3 commits conflicted; no semantic change vs. upstream, only
adjustments for structural gaps that predate this PR:
build.ymlcherry-picked cleanly (this branch already matchesmaster's
-Werror -g3layout).Makefile.am: the script/data lists already matched master, soonly the
intgcheck-prepare/-run/-cleantarget block conflictedand was dropped.
get-matrix.py: this branch has no usablefedoravariable inscope at the matrix-dict callsite, so the
multihost/systemmatrix stays centos-only.
pamsrv.c: this branch never had the laterLISTEN_PID/LISTEN_FDSsocket-activation env-clearing block, so just droppedthe dead
#ifndef INTGCHECK_BUILDguard.deps.sh/configure.sh: dropped the Debian-only package/configureblocks; kept this branch's own
passwddependency and avoidedduplicating
libcap-devel/systemtap-sdt-dtrace/etc. that alreadyexist here via other conditionals.
.github/workflows/coverity.ymlwas already deleted independentlyon this branch (
CI: disable coverity in maintenance branches) —kept it deleted.
.github/actions/build-sssd-srpm/action.yml: confirmed unused heretoo, deleted per the original commit's intent.
make-distcheckcompiled fine here (this branch'stest_ipa_subdomains_server.calready matches master's macro set),but the new
check-valgrindstep failed on a pre-existing Valgrindfalse positive (
libnl/libnl-routestatic-initializer "possiblylost" leak) inside a forked test child — already suppressed upstream
via
sssd-leak-netlinkincontrib/ci/sssd.supp, but thatsuppression had never been backported to this branch. Added it.
Original Pull Request Body
Remove the legacy Python/pytest-based intg test suite under
src/tests/intg along with its supporting build glue
(intgcheck.m4, contrib/ci --moderate scope, screenrc/cwrap config,
etc.). Coverage has moved to the system test suite
(src/tests/system) and to the make check test suite run under
Valgrind in GitHub Actions.
(.github/workflows/build.yml), since it previously ran via the
intgcheck job's contrib/ci/run --moderate invocation.
src/responder/pam/pamsrv.c; the macro is no longer defined
anywhere, so the guarded code (clearing dangerous env vars like
LDB_MODULES_PATH) always runs now.
contrib/ci/run (the MODERATE variable was set but never read once
the intg-backed moderate scope was removed) and update
contrib/ci/README.md to match.
level contrib/ci/run previously used for its Valgrind build, for
better Valgrind/backtrace output.
AI: Claude Sonnet 5
Co-authored-by: Cursor cursoragent@cursor.com