Repository navigation
Conversation
Remove the legacy Python/pytest-based intg test suite (src/tests/intg) and its build glue (intgcheck.m4, contrib/ci --moderate scope, screenrc/cwrap config). Coverage has moved to the system test suite (src/tests/system) and to make check under Valgrind in GitHub Actions. - Extract the Valgrind check into its own script, contrib/ci/check-valgrind. - Fix check-valgrind's log glob to recurse into SUBDIRS test directories. - Remove the now-dead INTGCHECK_BUILD guard in src/responder/pam/pamsrv.c. - Remove the AM_CHECK_PAM_WRAPPER/HAVE_SLAPD configure checks it needed. - Drop the unused --essential/--moderate run option. - Remove the obsolete run-multihost and clean scripts. - Update contrib/ci/README.md to match. - Remove the 'intgcheck' CI matrix entry and its GitHub Actions job. - Build make/make check/distcheck with -g3 for better Valgrind backtraces. AI: Claude Sonnet 5 Co-authored-by: Cursor <cursoragent@cursor.com> Reviewed-by: Alexey Tikhonov <atikhono@redhat.com> Reviewed-by: Pavel Březina <pbrezina@redhat.com>
danlavu
force-pushed
the
SSSD-sssd-backport-pr9078-to-sssd-2-10
branch
from
October 11, 2026 01:01
47d9f81 to
2f2dce3
Compare
…tab leak - Replace the two remaining "contrib/ci/run --deps-only" invocations with a direct call to deps_install(). - Remove contrib/ci/run and misc.sh, now without any callers. - Remove contrib/ci/README.md, which only documented the removed run entry point. - Trim deps.sh's DEPS_LIST of packages only needed by the legacy intg suite. - Remove the now-unused deps_remove()/distro_pkg_remove() helpers. - Remove the now-unreachable contrib/ci/sssd.debian.supp. - Reword the -g3 comment in build.yml's make step to explain it's for Valgrind. - Rename the 'multihost' CI matrix key to 'system'. - Remove the unused .github/actions/build-sssd-srpm composite action. AI: Claude Sonnet 5 Co-authored-by: Cursor <cursoragent@cursor.com> Reviewed-by: Alexey Tikhonov <atikhono@redhat.com> Reviewed-by: Pavel Březina <pbrezina@redhat.com> Co-authored-by: Cursor <cursoragent@cursor.com>
danlavu
force-pushed
the
SSSD-sssd-backport-pr9078-to-sssd-2-10
branch
3 times, most recently
from
October 11, 2026 02:51
a05924b to
3b8dd8d
Compare
danlavu
marked this pull request as ready for review
October 11, 2026 04:53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of PR#9078 tests: remove legacy intg test suite to branch sssd-2-10, created by @danlavu.
Original commits
cbdb054 - tests: remove legacy intg test suite
5ce9d9e - CI: trim unused deps.sh/distro.sh helpers, rename matrix key, fix keytab leak
056c2e7 - CI: drop Debian as a build target
Backported commits
Intentionally not backported
codeqljob at theci-client-develcontainermake-distcheckalready builds in, which has a newer OpenSSL where
ASN1_STRINGisopaque and
i2d_ASN1_TYPEis no longer usable the way this branch'ssrc/lib/certmap/sss_cert_content_crypto.cexpects —codeqlcurrently passes on this branch unmodified, and backporting this
commit broke it. A full fix requires a much larger, deliberate "Drop
support of OpenSSL < 3.0.8" effort (master PR Drop support of OpenSSL < 3.0.8 #8761) not yet applied
here, so this commit's scope reduction (Debian/Ubuntu removal from
CI) is left out of this backport rather than regress
codeql.Conflict resolution notes
Both backported commits conflicted on this branch; no semantic change
vs. upstream, only adjustments for structural gaps that predate this
PR:
build.yml: this branch doesn't have-Werroryet, so kept themake/make checkinvocations without it, just adding-g3andthe new
check-valgrindstep.Makefile.am: script/data lists conflicted because this branchhasn't absorbed a later, unrelated master-only reorg that moved
configure.sh/deps.sh/distro.sh/get-matrix.pyintodist_noinst_SCRIPTS; kept this branch's existing layout andapplied only this PR's actual deletions/additions. Also dropped the
entire
intgcheck-prepare/-run/-cleantarget block.get-matrix.py: this branch has no usablefedoravariable inscope at the matrix-dict callsite, so the
multihost/systemmatrix stays centos-only.
pamsrv.c: this branch has the dead#ifndef INTGCHECK_BUILDguard but never picked up the later
LISTEN_PID/LISTEN_FDSsocket-activation block, so just dropped the guard around the
existing
clearenv()code..github/workflows/coverity.ymlwas already deleted independentlyon this branch (
CI: disable coverity in maintenance branches) —kept it deleted.
One post-push
make-distcheckcompile failure found and fixed: theauto-merge of commit 2 carried over master's
unlink(IPA_ONEWAY_TWO_KEYTAB);keytab cleanup intotest_ipa_subdomains_server.c'stest_ipa_server_create_trusts_twoway(),but this branch's version of that test uses a single, simpler
ONEWAY_KEYTABmacro (noIPA_ONEWAY_TWO_KEYTAB) and already unlinksit in the shared teardown — so the line didn't apply and failed to
compile. Removed it; no real leak existed on this branch. This also
fixed the downstream
rpm-build/system (centos-10)/testing-farmfailures, which were all consequences of the same compile error.
Original Pull Request Body
Remove the legacy Python/pytest-based intg test suite under
src/tests/intg along with its supporting build glue
(intgcheck.m4, contrib/ci --moderate scope, screenrc/cwrap config,
etc.). Coverage has moved to the system test suite
(src/tests/system) and to the make check test suite run under
Valgrind in GitHub Actions.
(.github/workflows/build.yml), since it previously ran via the
intgcheck job's contrib/ci/run --moderate invocation.
src/responder/pam/pamsrv.c; the macro is no longer defined
anywhere, so the guarded code (clearing dangerous env vars like
LDB_MODULES_PATH) always runs now.
contrib/ci/run (the MODERATE variable was set but never read once
the intg-backed moderate scope was removed) and update
contrib/ci/README.md to match.
level contrib/ci/run previously used for its Valgrind build, for
better Valgrind/backtrace output.
AI: Claude Sonnet 5
Co-authored-by: Cursor cursoragent@cursor.com