Skip to content

[autobackport: sssd-2-10] tests: remove legacy intg test suite - #9427

Open
sssd-bot wants to merge 2 commits into
SSSD:sssd-2-10from
sssd-bot:SSSD-sssd-backport-pr9078-to-sssd-2-10
Open

sssd-bot wants to merge 2 commits into
SSSD:sssd-2-10from
sssd-bot:SSSD-sssd-backport-pr9078-to-sssd-2-10

Conversation

@sssd-bot

@sssd-bot sssd-bot commented Oct 10, 2026 •

Copy link
Copy Markdown
Contributor

This is an automatic backport of PR#9078 tests: remove legacy intg test suite to branch sssd-2-10, created by @danlavu.


Original commits
cbdb054 - tests: remove legacy intg test suite
5ce9d9e - CI: trim unused deps.sh/distro.sh helpers, rename matrix key, fix keytab leak
056c2e7 - CI: drop Debian as a build target

Backported commits

  • 3061a68 - tests: remove legacy intg test suite
  • 3b8dd8d - CI: trim unused deps.sh/distro.sh helpers, rename matrix key, fix keytab leak

Intentionally not backported

  • 056c2e7 - CI: drop Debian as a build target — this commit re-points the
    codeql job at the ci-client-devel container make-distcheck
    already builds in, which has a newer OpenSSL where ASN1_STRING is
    opaque and i2d_ASN1_TYPE is no longer usable the way this branch's
    src/lib/certmap/sss_cert_content_crypto.c expects — codeql
    currently passes on this branch unmodified, and backporting this
    commit broke it. A full fix requires a much larger, deliberate "Drop
    support of OpenSSL < 3.0.8" effort (master PR Drop support of OpenSSL < 3.0.8 #8761) not yet applied
    here, so this commit's scope reduction (Debian/Ubuntu removal from
    CI) is left out of this backport rather than regress codeql.

Conflict resolution notes

Both backported commits conflicted on this branch; no semantic change
vs. upstream, only adjustments for structural gaps that predate this
PR:

  • build.yml: this branch doesn't have -Werror yet, so kept the
    make/make check invocations without it, just adding -g3 and
    the new check-valgrind step.
  • Makefile.am: script/data lists conflicted because this branch
    hasn't absorbed a later, unrelated master-only reorg that moved
    configure.sh/deps.sh/distro.sh/get-matrix.py into
    dist_noinst_SCRIPTS; kept this branch's existing layout and
    applied only this PR's actual deletions/additions. Also dropped the
    entire intgcheck-prepare/-run/-clean target block.
  • get-matrix.py: this branch has no usable fedora variable in
    scope at the matrix-dict callsite, so the multihost/system
    matrix stays centos-only.
  • pamsrv.c: this branch has the dead #ifndef INTGCHECK_BUILD
    guard but never picked up the later LISTEN_PID/LISTEN_FDS
    socket-activation block, so just dropped the guard around the
    existing clearenv() code.
  • .github/workflows/coverity.yml was already deleted independently
    on this branch (CI: disable coverity in maintenance branches) —
    kept it deleted.

One post-push make-distcheck compile failure found and fixed: the
auto-merge of commit 2 carried over master's
unlink(IPA_ONEWAY_TWO_KEYTAB); keytab cleanup into
test_ipa_subdomains_server.c's test_ipa_server_create_trusts_twoway(),
but this branch's version of that test uses a single, simpler
ONEWAY_KEYTAB macro (no IPA_ONEWAY_TWO_KEYTAB) and already unlinks
it in the shared teardown — so the line didn't apply and failed to
compile. Removed it; no real leak existed on this branch. This also
fixed the downstream rpm-build/system (centos-10)/testing-farm
failures, which were all consequences of the same compile error.


Original Pull Request Body

Remove the legacy Python/pytest-based intg test suite under
src/tests/intg along with its supporting build glue
(intgcheck.m4, contrib/ci --moderate scope, screenrc/cwrap config,
etc.). Coverage has moved to the system test suite
(src/tests/system) and to the make check test suite run under
Valgrind in GitHub Actions.

  • Keep the make check-valgrind check in the distcheck job
    (.github/workflows/build.yml), since it previously ran via the
    intgcheck job's contrib/ci/run --moderate invocation.
  • Remove the now-dead INTGCHECK_BUILD guard in
    src/responder/pam/pamsrv.c; the macro is no longer defined
    anywhere, so the guarded code (clearing dangerous env vars like
    LDB_MODULES_PATH) always runs now.
  • Drop the now-unused --essential/--moderate option from
    contrib/ci/run (the MODERATE variable was set but never read once
    the intg-backed moderate scope was removed) and update
    contrib/ci/README.md to match.
  • Build make/make check/distcheck with -g3, matching the debug info
    level contrib/ci/run previously used for its Valgrind build, for
    better Valgrind/backtrace output.

AI: Claude Sonnet 5
Co-authored-by: Cursor cursoragent@cursor.com

Remove the legacy Python/pytest-based intg test suite (src/tests/intg)
and its build glue (intgcheck.m4, contrib/ci --moderate scope,
screenrc/cwrap config). Coverage has moved to the system test suite
(src/tests/system) and to make check under Valgrind in GitHub Actions.

- Extract the Valgrind check into its own script, contrib/ci/check-valgrind.
- Fix check-valgrind's log glob to recurse into SUBDIRS test directories.
- Remove the now-dead INTGCHECK_BUILD guard in src/responder/pam/pamsrv.c.
- Remove the AM_CHECK_PAM_WRAPPER/HAVE_SLAPD configure checks it needed.
- Drop the unused --essential/--moderate run option.
- Remove the obsolete run-multihost and clean scripts.
- Update contrib/ci/README.md to match.
- Remove the 'intgcheck' CI matrix entry and its GitHub Actions job.
- Build make/make check/distcheck with -g3 for better Valgrind backtraces.

AI: Claude Sonnet 5
Co-authored-by: Cursor <cursoragent@cursor.com>
Reviewed-by: Alexey Tikhonov <atikhono@redhat.com>
Reviewed-by: Pavel Březina <pbrezina@redhat.com>
@danlavu
danlavu force-pushed the SSSD-sssd-backport-pr9078-to-sssd-2-10 branch from 47d9f81 to 2f2dce3 Compare October 11, 2026 01:01
@danlavu danlavu added the no-backport This should go to target branch only. label Oct 11, 2026
…tab leak

- Replace the two remaining "contrib/ci/run --deps-only" invocations with a direct call to deps_install().
- Remove contrib/ci/run and misc.sh, now without any callers.
- Remove contrib/ci/README.md, which only documented the removed run entry point.
- Trim deps.sh's DEPS_LIST of packages only needed by the legacy intg suite.
- Remove the now-unused deps_remove()/distro_pkg_remove() helpers.
- Remove the now-unreachable contrib/ci/sssd.debian.supp.
- Reword the -g3 comment in build.yml's make step to explain it's for Valgrind.
- Rename the 'multihost' CI matrix key to 'system'.
- Remove the unused .github/actions/build-sssd-srpm composite action.

AI: Claude Sonnet 5
Co-authored-by: Cursor <cursoragent@cursor.com>
Reviewed-by: Alexey Tikhonov <atikhono@redhat.com>
Reviewed-by: Pavel Březina <pbrezina@redhat.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
@danlavu
danlavu force-pushed the SSSD-sssd-backport-pr9078-to-sssd-2-10 branch 3 times, most recently from a05924b to 3b8dd8d Compare October 11, 2026 02:51
@danlavu
danlavu marked this pull request as ready for review October 11, 2026 04:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-backport This should go to target branch only.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants