Mortgage Calc v2 edits#164
Open
jenbreese wants to merge 3 commits into
Open
Conversation
**Rounding discrepancy:** Total monthly housing cost now sums the rounded individual components (mortgage, taxes, insurance, HOA) instead of rounding the sum, so users who manually add the displayed values get the exact total shown. **Breakdown clearing:** When estimate is blocked by validation errors, all monthly breakdown rows now display dashes instead of attempting to show calculated values. **HOA input:** Accepts negative values and displays them with corresponding validation error message. **Property taxes:** Defaults back to 1.25% when switching from dollar amount mode back to percentage mode, instead of clearing to 0%. Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixed multiple rounding, validation, and UI display issues in the mortgage calculator:
Rounding consistency – Total monthly housing cost now sums the individually rounded values (mortgage + taxes + insurance + HOA) instead of rounding the sum. Users who manually add the displayed values now get the exact total shown.
Breakdown clearing on errors – When validation errors block calculation, all monthly breakdown rows now display dashes instead of showing stale/calculated values.
HOA negative input handling – Input box now accepts negative values and displays them with the validation error "Enter an amount between $0 and $20,000."
Property tax mode switching – When switching from dollar amount mode back to percentage mode, now defaults to 1.25% instead of clearing to 0%.
Changes
calculateMortgage()in both afford and payment modes to compute the total from rounded component valuesaffordDashandpaymentDashlogic to include blocking conditions, so all breakdown lines show dashes when validation blocks the estimate/^-?\d*$/) and fixed display formatting to show raw value when incompleteTesting
Tested rounding behavior:
🤖 Generated with Claude Code