Skip to content

Mortgage Calc v2 edits#164

Open
jenbreese wants to merge 3 commits into
devfrom
mort-calc-v2-0722
Open

Mortgage Calc v2 edits#164
jenbreese wants to merge 3 commits into
devfrom
mort-calc-v2-0722

Conversation

@jenbreese

@jenbreese jenbreese commented Jul 23, 2026

Copy link
Copy Markdown
Collaborator

Summary

Fixed multiple rounding, validation, and UI display issues in the mortgage calculator:

  1. Rounding consistency – Total monthly housing cost now sums the individually rounded values (mortgage + taxes + insurance + HOA) instead of rounding the sum. Users who manually add the displayed values now get the exact total shown.

  2. Breakdown clearing on errors – When validation errors block calculation, all monthly breakdown rows now display dashes instead of showing stale/calculated values.

  3. HOA negative input handling – Input box now accepts negative values and displays them with the validation error "Enter an amount between $0 and $20,000."

  4. Property tax mode switching – When switching from dollar amount mode back to percentage mode, now defaults to 1.25% instead of clearing to 0%.

Changes

  • Modified calculateMortgage() in both afford and payment modes to compute the total from rounded component values
  • Updated affordDash and paymentDash logic to include blocking conditions, so all breakdown lines show dashes when validation blocks the estimate
  • Updated HOA input regex to accept optional minus sign (/^-?\d*$/) and fixed display formatting to show raw value when incomplete
  • Fixed property tax percentage toggle to restore default 1.25% instead of 0

Testing

Tested rounding behavior:

  • Verified that sum of displayed rounded values equals total monthly housing cost
  • Confirmed validation errors cause all breakdown rows to show dashes
  • Verified HOA input accepts negative values and displays error
  • Confirmed property taxes reset to 1.25% when switching back to percentage mode

🤖 Generated with Claude Code

jenbreese and others added 3 commits July 22, 2026 17:02
**Rounding discrepancy:** Total monthly housing cost now sums the rounded individual components (mortgage, taxes, insurance, HOA) instead of rounding the sum, so users who manually add the displayed values get the exact total shown.

**Breakdown clearing:** When estimate is blocked by validation errors, all monthly breakdown rows now display dashes instead of attempting to show calculated values.

**HOA input:** Accepts negative values and displays them with corresponding validation error message.

**Property taxes:** Defaults back to 1.25% when switching from dollar amount mode back to percentage mode, instead of clearing to 0%.

Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants